320938 - autocompletion of a text-field pops up above firefox

Status: RESOLVED FIXED

(Toolkit :: Autocomplete, defect)

Description

[Michaël Arnauts]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; nl; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; nl; rv:1.8) Gecko/20051111 Firefox/1.5

Open the testcase: http://users.skynet.be/bk333867/testcase.html

Click inside the inputbox

Scroll down, without clicking inside the browserarea (so the cursor stays in the inputfield)

Press key down

You should see the combobox of the inputfield (with the previous entered words) appear on top of firefox.

Reproducible: Always

Steps to Reproduce:

Comment 1

[zug_treno]

Reproducible with Firefox 1.0.6 and Firefox 1.5 (Linux), related to bug 187772?

Comment 2

[Adam Guthrie]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20051220 Firefox/1.6a1

Masayuki's patch for bug 187772 does not fix this for me.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thanks, I'll create the patch.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Umm... the patch conflicts with bug 187772's patch.
We need to fix bug 187772 before this...

Comment 5

[Michael Wu [:mwu]]

Is the patch still around somewhere?

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

No, but I don't have much time for this now, if you can fix, please take this.

Comment 7

[Michael Wu [:mwu]]

(In reply to comment #6)
> No, but I don't have much time for this now, if you can fix, please take this.
> 
Sure, I'll take a look.

Comment 8

[Michael Wu [:mwu]]

Attachment: Make input field visible before opening popup

Comment 9

[Johnny Stenback (:jst)]

Comment on attachment 229183 [details] [diff] [review]
Make input field visible before opening popup

Looks like the right thing to do. r=jst

Comment 10

[Robert Strong (they/them - no direct email)]

Checked in to trunk

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 229183 [details] [diff] [review]
Make input field visible before opening popup

a=dbaron on behalf of drivers.  Please check in to MOZILLA_1_8_BRANCH and mark fixed1.8.1 after doing so.

Comment 12

[Michael Wu [:mwu]]

Attachment: Make input field visible before opening popup (branch)

The branch version of GetPrimaryFrameFor sucks.

Comment 13

[Martijn Wargers (dead)]

Checking in nsFormFillController.cpp;
/cvsroot/mozilla/toolkit/components/satchel/src/nsFormFillController.cpp,v  <--
 nsFormFillController.cpp
new revision: 1.51.4.13; previous revision: 1.51.4.12
done

Checked into 1.8.1 branch.

Comment 14

[Martijn Wargers (dead)]

*** Bug 336689 has been marked as a duplicate of this bug. ***