321020 - Lightning: The calendar list is empty after 'Publish Calendar'

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Stefan Sitter [:ssitter]]

Lightning: The calendar list is empty after 'Publish Calendar'

Thunderbird version 1.6a1 (20051220) + Lightning from same day

Steps to reproduce:

1. Right click calendar in calendar tab in side pane

2. Select 'Publish...'
   --> Publish dialog shows, JavaScript Console says:
       Warning: assignment to undeclared variable currentCalendar
         Source File: chrome://lightning/content/messenger-overlay-sidebar.js
         Line: 221

3. Enter URL and press 'Publish'
   --> The ics file is created, JavaScript Console says:
       Warning: reference to undefined property getCalendars()[index]
         Source File: chrome://lightning/content/messenger-overlay-sidebar.js
         Line: 9
       Error: calendar has no properties
         Source File: file:///<snip>/components/calCalendarManager.js
         Line: 183
       Error: calendar has no properties
         Source File: file:///<snip>/components/calCalendarManager.js
         Line: 183
   --> All calendars are still visible in calendar tab in side pane

4. Press Close or Cancel
   --> Publish dialog closes
   --> All calendars disappeared from calendar tab in side pane

Comment 1

[Stefan Sitter [:ssitter]]

After a first test it seems that the error happens during the deleteCalendar() call at http://lxr.mozilla.org/seamonkey/source/calendar/base/content/calendar-publish-dialog.js#114

Comment 2

[Stefan Sitter [:ssitter]]

Ok, removing the call to calCalendarManager:deleteCalendar seems to fix that error. Also there seems to be no additional calendar in the storage.sdb file without that call.

Question: 
Is it adequate just to remove that call to deleteCalendar()? Or does that has any side effects I'm not aware off?

Comment 3

[Joey Minta]

(In reply to comment #2)
> Ok, removing the call to calCalendarManager:deleteCalendar seems to fix that
> error. Also there seems to be no additional calendar in the storage.sdb file
> without that call.
> 
> Question: 
> Is it adequate just to remove that call to deleteCalendar()? Or does that has
> any side effects I'm not aware off?
> 

I'd say no, you can't just remove it.  Since we're registering the calendar in order to publish it, this would often leave the user with an extra calendar in their list.  I'd suggest trying to move Lightning to the Sunbird publishing code, since that seems to be working ok in that app at least, and has had some testing in 0.3a1.

Comment 4

[Joey Minta]

We don't want to break this easily in Lightning 0.1.  Adding to the block list, and tentatively assigning to Stefan, since he seems to have been looking into this.  Stefan, if you're not going to take this, please flip it back to "nobody".

Comment 5

[Joey Minta]

The work on bug 323183 ought to have fixed this.