including the API which forces dllimport causes conflicts for modules that are trying to dllexport

ASSIGNED
Assigned to

Status

()

Toolkit
Startup and Profile System
ASSIGNED
12 years ago
4 months ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
r:/mozilla\toolkit\profile\src\nsToolkitProfileService.cpp(864) : warning C4273: 'XRE_GetFileFromPath' : inconsistent dll linkage
(Assignee)

Comment 1

12 years ago
Created attachment 206476 [details] [diff] [review]
don't dllimport stuff which you're implementing
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #206476 - Flags: first-review?(benjamin)

Comment 2

12 years ago
Comment on attachment 206476 [details] [diff] [review]
don't dllimport stuff which you're implementing

Isn't this header included by reference anyway from nsXREDirProvider.h/nsAppRunner.h? I don't understand what you're trying to fix here.

Comment 3

12 years ago
Comment on attachment 206476 [details] [diff] [review]
don't dllimport stuff which you're implementing

The correct fix is probably to add DEFINES += -DIMPL_XREAPI to additional makefiles.
Attachment #206476 - Flags: first-review?(benjamin) → first-review-
(Assignee)

Comment 4

12 years ago
benjamin: well, this worked...

Comment 5

10 years ago
So would this be fixed by the patch that I just uploaded to bug 390046 (attachment 280261 [details] [diff] [review])?
(Assignee)

Updated

10 years ago
Component: XRE Startup → Startup and Profile System
QA Contact: xre.startup → startup
You need to log in before you can comment on or make changes to this bug.