321081 - at-poke shows Mozilla as application name when running Firefox

Status: RESOLVED FIXED

(Firefox :: Disability Access, defect)

Description

[Nian Liu(n/a in a long time)]

1.run firefox
2.start at-poke

expected result:
  firefox shows in application list

actural result:
  mozilla shows in application list

Comment 1

[Nian Liu(n/a in a long time)]

for patch, refer to bug230144

Comment 2

[Ginn Chen]

Attachment: patch

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I think GetBrandShortName should take an nsAString& parameter for output.

Is it really necessary to cache the result?

Comment 4

[Ginn Chen]

Attachment: patch v2 (addressing roc's comment)

roc's comment makes sense to me.

Comment 5

[Ginn Chen]

Checking in nsAppRootAccessible.cpp;
/cvsroot/mozilla/accessible/src/atk/nsAppRootAccessible.cpp,v  <--  nsAppRootAccessible.cpp
new revision: 1.14; previous revision: 1.13
done

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Is this string designed to be presented to users or read by programs?  Should you really be using a localizable string?

Comment 7

[Ginn Chen]

Present to user

Comment 8

[Willie Walker]

I think Window/Frame/Dialog names tend to be human consumable, but the name of the top level application object (i.e., the parent of all windows/frames/dialogs of the app) tends to be a programmatic, non-localized string that typically reflects the name of the binary used to start the application.

Comment 9

[Ginn Chen]

I think app name should be localizable, but program name should not.

See glib manual:

g_get_application_name ()

Gets a human-readable name for the application, as set by g_set_application_name(). This name should be localized if possible, and is intended for display to the user. Contrast with g_get_prgname(), which gets a non-localized name.

Comment 10

[Ginn Chen]

Checking in src/atk/nsAppRootAccessible.cpp;
/cvsroot/mozilla/accessible/src/atk/nsAppRootAccessible.cpp,v  <--  nsAppRootAccessible.cpp
new revision: 1.11.26.1; previous revision: 1.11
done

Comment 11

[Aaron Leventhal]

*** Bug 309789 has been marked as a duplicate of this bug. ***