1.run firefox 2.start at-poke expected result: firefox shows in application list actural result: mozilla shows in application list
for patch, refer to bug230144
Created attachment 207968 [details] [diff] [review] patch
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #207968 - Flags: review?(aaronleventhal)
Attachment #207968 - Flags: review?(aaronleventhal) → review+
I think GetBrandShortName should take an nsAString& parameter for output. Is it really necessary to cache the result?
Created attachment 210745 [details] [diff] [review] patch v2 (addressing roc's comment) roc's comment makes sense to me.
Checking in nsAppRootAccessible.cpp; /cvsroot/mozilla/accessible/src/atk/nsAppRootAccessible.cpp,v <-- nsAppRootAccessible.cpp new revision: 1.14; previous revision: 1.13 done
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Attachment #210745 - Flags: branch-1.8.1?(aaronleventhal)
Is this string designed to be presented to users or read by programs? Should you really be using a localizable string?
Present to user
I think Window/Frame/Dialog names tend to be human consumable, but the name of the top level application object (i.e., the parent of all windows/frames/dialogs of the app) tends to be a programmatic, non-localized string that typically reflects the name of the binary used to start the application.
I think app name should be localizable, but program name should not. See glib manual: g_get_application_name () Gets a human-readable name for the application, as set by g_set_application_name(). This name should be localized if possible, and is intended for display to the user. Contrast with g_get_prgname(), which gets a non-localized name.
Summary: at-poke shows Mozila as application name when running Firefox → at-poke shows Mozilla as application name when running Firefox
Version: unspecified → Trunk
Attachment #210745 - Flags: approval-branch-1.8.1?(aaronleventhal) → approval-branch-1.8.1+
Checking in src/atk/nsAppRootAccessible.cpp; /cvsroot/mozilla/accessible/src/atk/nsAppRootAccessible.cpp,v <-- nsAppRootAccessible.cpp new revision: 220.127.116.11; previous revision: 1.11 done
*** Bug 309789 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.