321180 - nsXULTemplateBuilder::CompileQueries string parsing is weak

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Neil Deakin]

The parsing of the flags attribute is weak.

    if (flags.Find(NS_LITERAL_STRING("dont-test-empty")) >= 0)
        mFlags |= eDontTestEmpty;

It doesn't look for surrounding whitespace for example.

Comment 1

[Neil Deakin]

Attachment: better space-separated handling for flags and sort keys

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 350956 [details] [diff] [review]
better space-separated handling for flags and sort keys

>+    // see if they are empty. If dont-recurse is set, then don't process the
>+    // template recursively and only show one level of results.
>+    nsWhitespaceTokenizer tokenizer(flags);
>+    while (tokenizer.hasMoreTokens()) {
>+      nsAutoString token(tokenizer.nextToken());

This will end up copying. You can avoid it by using nsDependentSubstring instead.

r/sr=me with that