Don't link to libdl on BeOS

RESOLVED FIXED in mozilla1.9alpha1

Status

P2
normal
RESOLVED FIXED
13 years ago
6 months ago

People

(Reporter: Biesinger, Assigned: Biesinger)

Tracking

Trunk
mozilla1.9alpha1
x86
BeOS

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 2 obsolete attachments)

NSPR uses native functions for that; the libdl dependency is not necessary.
Attachment #206604 - Flags: review?(benjamin)
Comment on attachment 206604 [details] [diff] [review]
patch

nevermind, this is neither sufficient nor does it build
Attachment #206604 - Flags: review?(sergei_d)
Attachment #206604 - Flags: review?(benjamin)
Created attachment 206615 [details] [diff] [review]
working patch
Attachment #206604 - Attachment is obsolete: true
Attachment #206615 - Flags: review?(benjamin)
Attachment #206615 - Flags: review?(sergei_d)
Status: NEW → ASSIGNED
Priority: -- → P2
Hardware: Other → PC
Target Milestone: --- → mozilla1.9alpha
Created attachment 206618 [details] [diff] [review]
don't link to iconv either

while I'm here, don't link to libiconv either (the native charset functions for beos just use our UTF-8 functions)
Attachment #206618 - Flags: review?(sergei_d)
Attachment #206618 - Flags: review?(benjamin)

Comment 5

13 years ago
Comment on attachment 206615 [details] [diff] [review]
working patch

good idea.
now i can freely put that damn libdl to libpath on my build-machine:)
(and, looking at patch, libm is also no-go under BeOS, as it is part of libroot curently)
Attachment #206615 - Flags: review?(sergei_d) → review+

Comment 6

13 years ago
Comment on attachment 206618 [details] [diff] [review]
don't link to iconv either

r.
Attachment #206618 - Flags: review?(sergei_d) → review+

Updated

13 years ago
Attachment #206618 - Flags: review?(benjamin) → review+

Updated

13 years ago
Attachment #206615 - Flags: review?(benjamin) → review+
Created attachment 206625 [details] [diff] [review]
NSPR part

this is the NSPR part split out from the above patches
Attachment #206625 - Flags: review?(wtchang)
non-NSPR changes checked in:
Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1576; previous revision: 1.1575
done

Comment 9

13 years ago
Comment on attachment 206625 [details] [diff] [review]
NSPR part

r=wtc.

> case $target in
> *-darwin*)
>     ;;
>+*-beos*)
>+    ;;

We can combine these two cases into one:

  *-darwin*|*-beos*)
      ;;
Attachment #206625 - Flags: review?(wtchang) → review+
Created attachment 206649 [details] [diff] [review]
NSPR part, v2
Attachment #206625 - Attachment is obsolete: true
wtc, could you check the NSPR part in? I seem to recall that the NSPR partition is restricted, so I can't.

Comment 12

13 years ago
Comment on attachment 206649 [details] [diff] [review]
NSPR part, v2

I checked in this patch on the NSPR tip (NSPR 4.7 beta):

Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.207; previous revision: 1.206
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.209; previous revision: 1.208
done

and on the NSPRPUB_PRE_4_2_CLIENT_BRANCH (Mozilla/Gecko
1.9 alpha):

Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.78.2.125; previous revision: 1.78.2.124
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.83.2.123; previous revision: 1.83.2.122
done
Attachment #206649 - Flags: review+
thanks, that makes this bug fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Updated

6 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.