321230 - Don't link to libdl on BeOS

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P2)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

NSPR uses native functions for that; the libdl dependency is not necessary.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 206604 [details] [diff] [review]
patch

nevermind, this is neither sufficient nor does it build

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: working patch

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: don't link to iconv either

while I'm here, don't link to libiconv either (the native charset functions for beos just use our UTF-8 functions)

Comment 5

[Sergei Dolgov]

Comment on attachment 206615 [details] [diff] [review]
working patch

good idea.
now i can freely put that damn libdl to libpath on my build-machine:)
(and, looking at patch, libm is also no-go under BeOS, as it is part of libroot curently)

Comment 6

[Sergei Dolgov]

Comment on attachment 206618 [details] [diff] [review]
don't link to iconv either

r.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: NSPR part

this is the NSPR part split out from the above patches

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

non-NSPR changes checked in:
Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1576; previous revision: 1.1575
done

Comment 9

[Wan-Teh Chang]

Comment on attachment 206625 [details] [diff] [review]
NSPR part

r=wtc.

> case $target in
> *-darwin*)
>     ;;
>+*-beos*)
>+    ;;

We can combine these two cases into one:

  *-darwin*|*-beos*)
      ;;

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: NSPR part, v2

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

wtc, could you check the NSPR part in? I seem to recall that the NSPR partition is restricted, so I can't.

Comment 12

[Wan-Teh Chang]

Comment on attachment 206649 [details] [diff] [review]
NSPR part, v2

I checked in this patch on the NSPR tip (NSPR 4.7 beta):

Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.207; previous revision: 1.206
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.209; previous revision: 1.208
done

and on the NSPRPUB_PRE_4_2_CLIENT_BRANCH (Mozilla/Gecko
1.9 alpha):

Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.78.2.125; previous revision: 1.78.2.124
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.83.2.123; previous revision: 1.83.2.122
done

Comment 13

[Christian :Biesinger (don't email me, ping me on IRC)]

thanks, that makes this bug fixed.