Closed
Bug 321274
Opened 19 years ago
Closed 16 years ago
Teach mfcEmbed about an imaginary toolkit profile service
Categories
(Core Graveyard :: Embedding: MFC Embed, defect)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: timeless, Assigned: timeless)
Details
(Keywords: crash)
Attachments
(2 files)
9.72 KB,
patch
|
benjamin
:
review-
|
Details | Diff | Splinter Review |
442 bytes,
patch
|
Details | Diff | Splinter Review |
currently mfcEmbed crashes if it can't find an xpfe profile service.
Attachment #206643 -
Flags: review?(benjamin)
Comment 2•19 years ago
|
||
To build timeless' patch with a xulrunner build. We need to include nsIToolkitProfile.h and nsIToolkitProfileService.h
Comment 3•19 years ago
|
||
Comment on attachment 206643 [details] [diff] [review]
handle missing profile services and try to get imaginary toolkit services
I don't think this is a good idea, and I don't want to go around exposing the toolkit profile service; see bug 321359 for how I wish to expose profile locking to embedding apps (locking, not a profile manager).
If we were going to expose the toolkit profile service, it would need a lot of cleanup (it does nasty stuff like casting nsIToolkitProfileService* back to nsToolkitProfileService* without safety-QI and such).
Attachment #206643 -
Flags: review?(benjamin) → review-
Updated•16 years ago
|
QA Contact: dunn5557 → mfcembed
Comment 4•16 years ago
|
||
mfcembed is dead (and the xre has profile functions now).
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → INCOMPLETE
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•