321343 - Line breaks in user comments not rendered

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Michael Buschbeck]

User-Agent:       Opera/8.50 (Windows NT 5.1; U; de)
Build Identifier: 

Line breaks (or paragraphs) in user comments aren't rendered correctly; even if the comment contained line breaks, it appears as a big (and rather illegible) blob of text in the browser.

Reproducible: Always

Steps to Reproduce:
1. Write a user comment for an extension.  Include some line breaks to split it into multiple paragraphs (to improve legibility).

Actual Results:  
The line breaks have disappeared when the comment is viewed on the website.  Text following a line break is separated from the text preceding it by a mere space character.

Expected Results:  
Text following a line break should start at the beginning of the next line after the text preceding it (i.e. line breaks should be rendered as <br> into the HTML source).

Comment 1

[Cameron]

Agreed. May also want to implement some code to make the maximum number of line breaks 2 at a time.

Comment 2

[Cameron]

Attachment: Adds |nl2br to comment text

Not sure how strip_tags and nl2br will work together. Morgamic?

Comment 3

[Michael Morgan [:morgamic]]

Thanks, Cameron -- committed.  :)