321344 - [trunk] Google maps/gmail compose is broken

Status: VERIFIED FIXED

(Core :: DOM: HTML Parser, defect, P2)

Description

[Brian Polidoro]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051223 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051223 Firefox/1.6a1

Google maps no longer works in the 12-23 nightly.  The error given in the console is:
Error: a has no properties
Source File: http://maps.google.com/mapfiles/maps.30a.js
Line: 647

Reproducible: Always

Actual Results:  
No map is shown.


I went back and confirmed that this works in 1.5 and it works in the 12-22 nightly.  So this does not seem like something that changed on google's end.

Comment 1

[Peter van der Woude [:Peter6]]

regressed between:
works in 20051222 1154 pdt build
fails in 20051222 1500 pdt build 

chickens:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&filetype=match&whotype=match&sortby=Date&hours=2&date=explicit&mindate=20051222+115200&maxdate=20051222+150000&cvsroot=%2Fcvsroot

probably Bug 316582

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

*** Bug 321345 has been marked as a duplicate of this bug. ***

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Oops

The original code looked like:
PRBool firstTime = PR_TRUE;
PRBool theIterationIsOk = firstTime || ...;

I was trying to be too clever, this fixes things.

Comment 4

[Brendan Eich [:brendan]]

I'd say to restore the trunk's honor, this should land ASAP, even before review, if the patch fixes the bug and doesn't introduce any others that can be found by the usual smoketesting (which must include maps and gmail compose, henceforth!).

/be

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

I checked this into the trunk.

Comment 6

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20051224 Firefox/1.6a1 ID:2005122401

Verified on Win32

Comment 7

[Uri Bernstein]

*** Bug 321372 has been marked as a duplicate of this bug. ***

Comment 8

[Peter Van der Beken [:peterv]]

Comment on attachment 206716 [details] [diff] [review]
Oops

Oh :-(.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED with both

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051225 Firefox/1.6a1
 
and SeaMonkey 1.5a;Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051224 Mozilla/1.0