321368 - problem with the mozilla/security/nss/pkg/linux Makefile invoking rpm -ba ...

Status: RESOLVED DUPLICATE of bug 238319

(NSS :: Build, defect)

Description

[Peter Djalaliev]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20051221 Firefox/1.5

As far as I know, this problem exists for NSS versions 3.9, 3.9.2 and 3.10

When I download the NSS source code, run 'gmake nss_build_all' in mozilla/security/nss and then run 'gmake package' in the same directory, I get en error from the Makefile in mozilla/security/nss/pkg/linux because it invokes the 'rpm' too with the '-ba' command line option.  However, '-ba' is not a valid option for rpm anymore.  A forum posting I found online says that rpmbuild should be used instead of rpm.  When I made the pkg/linux Makefile, everything works fine.

Reproducible: Always

Steps to Reproduce:
1. Download the source code of NSS 3.9, 3.9.2 or 3.10
2. Build NSS with 'gmake nss_build_all' in mozilla/security/nss
3. Run 'gmake package'

Actual Results:  
The error returned is:
-ba: unknown option

Expected Results:  
It should have just built the RPM package

Comment 1

[Wan-Teh Chang]

Peter, thanks for the bug report.  Christophe, could
you take a look at this?

Comment 2

[timeless]

this is already fixed in 3.11

the relevant change is:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=/mozilla/security/nss/pkg/linux&command=DIFF_FRAMESET&file=Makefile&rev2=1.12&rev1=1.11

from:
http://bonsai.mozilla.org/cvsgraph.cgi?file=/mozilla/security/nss/pkg/linux/Makefile
you can see that nss3.10.x is based on 1.10 of the file and from blame you can see it was fixed in 1.12

unless you have some need for the fix to be backported, i'm resolving this as a duplicate of the bug that fixed it.

if you want this fixed, feel free to reopen and post the backporting patch. although i have no idea whether or not nss will actually take it. heck, if you want it fixed, reopen it and send me an email and i can post the patch, but i still can't guarantee it'd be fixed (and i have hundreds of things to do, so i'd much rather not be responsible for adopting backports to some old nss release).

*** This bug has been marked as a duplicate of 238319 ***