qute : pixel missing at the bottom of smileys - consistency with other themes

RESOLVED FIXED in Thunderbird 3

Status

Thunderbird
Message Compose Window
--
trivial
RESOLVED FIXED
13 years ago
12 years ago

People

(Reporter: Thomas Bertels, Assigned: Thomas Bertels)

Tracking

({fixed1.8.1.3})

Thunderbird 3
fixed1.8.1.3
Bug Flags:
blocking-thunderbird2 -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

13 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Thunderbird 1.5RC2 (Gecko/1.8.20051201.15)

The lower pixel of smileys is missing with the qute theme. This can be fixed by increasing their font-size from 15 to 16 pixels.
But all other themes have a font-size set to 17 pixels (this avoid the difference of height between smileys and text when selected), so why not qute too.

Reproducible: Always

Steps to Reproduce:
(Assignee)

Comment 1

13 years ago
Created attachment 206737 [details] [diff] [review]
font-size 15 -> 17 pixels
Attachment #206737 - Flags: review?
(Assignee)

Updated

13 years ago
Attachment #206737 - Flags: review? → review?(ducarroz)
(Assignee)

Updated

13 years ago
Version: unspecified → 1.5

Updated

13 years ago
Attachment #206737 - Flags: superreview?(bienvenu)
Attachment #206737 - Flags: review?(ducarroz)
Attachment #206737 - Flags: review+

Updated

13 years ago
Attachment #206737 - Flags: superreview?(bienvenu) → superreview+
(Assignee)

Updated

13 years ago
Whiteboard: [checkin needed]
Assignee: mscott → tbertels
Status: UNCONFIRMED → NEW
Ever confirmed: true
mozilla/toolkit/themes/qute/communicator/smileys.css 	1.5
Status: NEW → RESOLVED
Last Resolved: 12 years ago
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → Thunderbird 3
Version: 1.5 → Trunk

Comment 3

12 years ago
Im pretty sure this patch isn't going to do anything. Thunderbid no longer builds tookit\themes\qute, instead we use winstripe now. I haven't checked in the code to cvs remove the files yet. 
Thomas, can you confirm that this isn't a problem with recent thunderbird builds?
(Assignee)

Comment 5

12 years ago
This is still a problem both with Thunderbird 1.5 (20051201) and Thunderbird 3 alpha 1 (20060416).
Does the same patch need to be applied to winstripe?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 7

12 years ago
In fact, it seems that the smileys.css file used is located in \mail\themes\qute\mail, and indeed the font-size is still 15px there.
So I think the patch should be applied there.

\toolkit\themes\winstripe is taken and then \mail\themes\qute\mail is added to get the complete Thunderbird theme (for Firefox, it's \browser\themes\winstripe\browser).
There's some redundancy with the mail and browser directories (why the last subdirectory ?).
(Assignee)

Comment 8

12 years ago
Created attachment 220814 [details] [diff] [review]
Same patch for qute (font-size 15 -> 17 pixels)
Attachment #220814 - Flags: review?(ducarroz)
Comment on attachment 220814 [details] [diff] [review]
Same patch for qute (font-size 15 -> 17 pixels)

R=ducarroz
Attachment #220814 - Flags: review?(ducarroz) → review+

Updated

12 years ago
Attachment #220814 - Flags: superreview?(bienvenu)

Updated

12 years ago
Attachment #220814 - Flags: superreview?(bienvenu) → superreview+
(Assignee)

Updated

12 years ago
Whiteboard: [checkin needed]
mozilla/mail/themes/qute/mail/smileys.css 	1.4
Status: REOPENED → RESOLVED
Last Resolved: 12 years ago12 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
(Assignee)

Comment 11

12 years ago
Couldn't it also be fixed in mozilla1.8 ?
Flags: blocking-thunderbird2?
(Assignee)

Updated

12 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Version: Trunk → 1.5

Comment 12

12 years ago
not a blocker  ut I did just land this on the 1.8 branch for thunderbird. thanks for the patch!

I'm going to re-close this bug now as well.
Status: REOPENED → RESOLVED
Last Resolved: 12 years ago12 years ago
Flags: blocking-thunderbird2? → blocking-thunderbird2-
Keywords: fixed1.8.1.3
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.