321578 - Files dragged onto tabbar from explorer don't open in new tabs anymore

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Sander]

I always open lots of files in SeaMonkey by dragging them over onto an empty part of the tabbar directly from Explorer. Especially my photography workflow depends completely on this behaviour, as I do the first comparison of similars by quickly dragging them over to the browser to appear in tabs side by side.
Starting - presumably - with the tab reordering implementation, this doesn't work anymore, and instead new files are opened in the current tab. Highly annoying for the photography workflow - now I need to insert ctrl-t in between the drags - and potentially destructive dataloss if you drag a file over while the current tab contains formdata.

If tab reordering isn't responsible and it's unknown when this bug was introduced, let me know and I'll track down the regression window. I care a lot about this.

Comment 1

[Sander]

This has reportedly been fixed on trunk, but still needs fixing on branch (tested with 2005122609). Can't figure out which patch it is that hasn't been checked in on branch (nor can I find a separate bug for it), so keeping this open for the nonce to help remind CTho. :)

Comment 2

[Worcester12345]

(In reply to comment #1)
> This has reportedly been fixed on trunk, but still needs fixing on branch
> (tested with 2005122609). Can't figure out which patch it is that hasn't been
> checked in on branch (nor can I find a separate bug for it), so keeping this
> open for the nonce to help remind CTho. :)
> 

This is marked as a Trunk bug. Is there a field where it can be noted "fixed-trunk"?

Comment 3

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Did I diff this correctly?
http://bonsai.mozilla.org/cvsview2.cgi?command=DIFF&subdir=mozilla%2Fxpfe%2Fglobal%2Fresources%2Fcontent%2Fbindings&file=tabbrowser.xml&rev1=1.126.2.8&rev2=1.135&whitespace_mode=show&diff_mode=context

Comment 4

[Sander]

This is not in fact fixed on trunk (I now figure it's windows only, and that that why it reportedly wasn't present on trunk).
Regressed between 2005121309 and 2005121409.

Comment 5

[Sander]

Most likely a regression from bug 319244.

Comment 6

[jag (Peter Annema)]

Attachment: Null check aDragSession.sourceNode

Comment 7

[jag (Peter Annema)]

Comment on attachment 207007 [details] [diff] [review]
Null check aDragSession.sourceNode

<CTho|away> r=me

Comment 8

[jag (Peter Annema)]

Checking in tabbrowser.xml;
/cvsroot/mozilla/xpfe/global/resources/content/bindings/tabbrowser.xml,v  <--  tabbrowser.xml
new revision: 1.136; previous revision: 1.135
done

Comment 9

[Robert Kaiser]

Comment on attachment 207007 [details] [diff] [review]
Null check aDragSession.sourceNode

a=me for 1.1

For 1.0, count in my a+ as well, but needs one other Council member to agree.

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 207007 [details] [diff] [review]
Null check aDragSession.sourceNode

a=me for 1.0

Comment 11

[Stefan [:stefanh]]

Hmm, it looks like this was never checked in to MOZILLA_1_8_BRANCH.

Comment 12

[jag (Peter Annema)]

I checked in to the 1_8_0_BRANCH sometime last week. Just now I did the 1_8_BRANCH.

Checking in tabbrowser.xml;
/cvsroot/mozilla/xpfe/global/resources/content/bindings/tabbrowser.xml,v  <--  tabbrowser.xml
new revision: 1.126.2.9; previous revision: 1.126.2.8
done