Closed Bug 321730 Opened 19 years ago Closed 18 years ago

libjar returns an error when asking for the realSize of 0-byte nsIZipEntries

Categories

(Core :: Networking, defect)

Product:
Core
Component:
Networking
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: Gijs, Assigned: darin.moz)

References

(
URL
)

Details

http://lxr.mozilla.org/mozilla/source/modules/libjar/nsJAR.cpp#1117

1124     if (!mZipItem->realsize)
1125         return NS_ERROR_FAILURE;

Should be done differently. According to timeless it's a 3-line patch, but I honestly don't know Core well enough to do it myself (though it seems simple enough).
Is it possible for mZipItem->realsize to be negative or null?  If so, we should just add a second check in the if statement instead of removing the nullcheck.
Depends on: 309296
This should be fixed by bug 309296; please reopen if it wasn't.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.