321732 - printjoboptions.properties is dead, the other printjoboptions.* files should be packaged on non-Mac Unix only

Status: RESOLVED FIXED

(Toolkit :: Printing, defect)

Description

[:Gijs (he/him)]

<mconnor> Hannibal, printjoboptions.properties is dead and should be removed, period, the other printjoboptions.* files should be packaged on non-Mac Unix only, basically.

(the (other) files are #ifdef UNIX-ed to being empty, but since we can preprocess this stuff in jar.mn now, we should)

References:

http://lxr.mozilla.org/seamonkey/source/toolkit/locales/en-US/chrome/global/printjoboptions.properties
http://lxr.mozilla.org/seamonkey/source/toolkit/components/printing/content/printjoboptions.js
http://lxr.mozilla.org/seamonkey/source/toolkit/components/printing/content/printjoboptions.xul
(http://lxr.mozilla.org/seamonkey/source/toolkit/locales/en-US/chrome/global/printjoboptions.dtd ? )

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch, I think

Builds, I think this is right, will double check later.

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 207006 [details] [diff] [review]
patch, I think

r=me, but don't preprocess out the locale files, those should be identical cross-platform

Comment 3

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/components/printing/jar.mn; new revision: 1.12;
mozilla/toolkit/components/printing/content/printjoboptions.js; new revision: 1.7;
mozilla/toolkit/components/printing/content/printjoboptions.xul;
new revision: 1.7;
mozilla/toolkit/locales/jar.mn; new revision: 1.26;
mozilla/toolkit/locales/en-US/chrome/global/printjoboptions.properties;
new revision: delete;

Comment 4

[Axel Hecht [:Pike]]

Could we back-out the jar.mn #ifdef's?

That's unnecessarily makes language packs being platform dependent.
I really doubt we'll blow the 5MB for that one DTD.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

I checked that part in accidentally, and reverted it a few minutes later.