321791 - mailViews.dat should be in mail.xpi

Status: VERIFIED FIXED

(Thunderbird :: Installer, defect)

Description

[Pavel Franc - Mozilla.cz]

There is no ab-CD.xpi/bin/defaults/messenger/mailViews.dat in the repacked installer (tested for cs.xpi, pl.xpi and de.xpi) in contrary of en-US.xpi 

The l10n issue was fixed in bug 223292 and nightly zips are fine - ie. there is thunderbird/defaults/messenger/mailViews.dat.

Comment 1

[Axel Hecht [:Pike]]

What's the effect of this in real life?

Comment 2

[Pavel Franc - Mozilla.cz]

The effect is that there are no default mail views (People I Know, 
Recent Mail, Last 5 Days, Not Junk, ...) if you use the windows installer of l10n builds and you create a new profile or install Thunderbird for the first time.

Comment 3

[Pavel Franc - Mozilla.cz]

Since mailViews.dat is not part of l10n files (see bug 223292) it should be placed in mail.xpi for all locales, and then we don't need to care about it while repacking.

Wouldn't be enough to move it in
http://lxr.mozilla.org/mozilla1.8/source/mail/installer/windows/packages-static ?

BTW: If it is not clear this is all abut the windows installer and windows xpi files.

Comment 4

[Axel Hecht [:Pike]]

I'm afraid this could block the release of tb1.5 on windows.

How much time do we need to redo the windows installer bits for all locales?

How much effort do we need for QA?

Comment 5

[Axel Hecht [:Pike]]

Attachment: move mailViews.dat into mail.xpi

I'm not able to produce a working installer for tb on windows right now, but
this fixes the en-US and mail.xpi included in the installer, and yes, the
repackaging just removes en-US.xpi and builds a new one from scratch without
looking into packages-static.

Requesting r and sr, I'm not religious on who's doing which.

Comment 6

[Tim Riley [:timr]]

We don't have a lot of bandwidth right now to re-QA this in-house.  We can spotcheck a few locales.  This will probably take two people about a half a day.

Comment 7

[Scott MacGregor]

I downloaded a German build of RC2. Clean Profile, clean installation directory.  Started up, migrated from mozilla/netscape 7 and got a full list of default localized mail view names in the mail views drop down box in the toolbar.

It turns out this only effects new users who do NOT migrate from mozilla and do not have a profile already. 

And the information missing from the views combo box are a set of pre-filled message views we thought would be helpful, so we added them to 'prime the message view pump' feature. 

I'm not sure I'd consider this a showstopper if these items are missing for a brand new user. They can easily be created by customizing a mail view (which is what we did to create this initial list).

The feature still works, there's nothing broken just some of the initial items to get you started aren't listed. And if you know they are there, then you are probably coming from mozilla or thunderbird 1.0 anyway and you won't get bitten by this.

My two cents anyway :).

Comment 8

[Scott MacGregor]

regression from 1.0 with very low impact. Effects thunderbird only, no impact to firefox so I'm plussing for the appropriate branches.

Comment 9

[Scott MacGregor]

1.8.0.2 is technically the first release with this Thunderbird fix. 

Comment 10

[Tracy Walker [:tracy]]

verified mailViews.dat is in mail.xpi (2006-03-08)