pldhash.c includes nscore.h which uses c++ comments

VERIFIED FIXED

Status

()

VERIFIED FIXED
13 years ago
13 years ago

People

(Reporter: timeless, Assigned: benjamin)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

13 years ago
pldhash.c
In file included from /mnt/scratch/mozhack/mozilla/xpcom/glue/pldhash.h:45,
                 from /mnt/scratch/mozhack/mozilla/xpcom/glue/pldhash.c:48:
../../dist/include/xpcom/nscore.h:257:1: warning: C++ style comments are not allowed in ISO C90
../../dist/include/xpcom/nscore.h:257:1: warning: (this will be reported only once per input file)

does pldhash.c need nscore.h?
(Reporter)

Comment 1

13 years ago
plevent.c
timeless: I bet cvsblame would help assign this better.  You wanted bsmedberg, not dougt.

/be
Assignee: dougt → benjamin
(Assignee)

Comment 3

13 years ago
That block is #if 0

What the hell? Why would the preprocessor tokenize blocks that are ifdefed out?
(Assignee)

Comment 4

13 years ago
Fixed on trunk.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Integrated tokenizer and pre-processor, someone didn't think to suppress warnings in #if 0 code.  File a bug against GCC?

/be
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.