Closed Bug 321939 Opened 19 years ago Closed 15 years ago

Legacy XUL attribute 'xulkey'

Categories

(Core :: XUL, defect)

Product:
Core
Component:
XUL
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: mnyromyr, Assigned: sgautherie)

References

(
URL
)

Details

Attachments

(2 files, 1 obsolete file)

(Av1-CC) /suite/* [Checkin: Comment 10]
6.09 KB, patch
mnyromyr
: review+
Details | Diff | Splinter Review
(Bv2) DOMi, whitespace cleanup only [Checkin: Comment 9]
2.30 KB, patch
Details | Diff | Splinter Review 
Many <key>s in all products/projects still set an attribute 'xulkey', to various values like 'true', 'false', 'meta' or 'ctrl'. But LXR suggests that this attribute isn't used neither in any CSS nor is it processed by any backend code (anymore): <http://lxr.mozilla.org/mozilla/search?string=xulkey>

Since having an unused/unsupported, undocumented attribute is quite confusing, it should be removed.
Sounds fine, if mconnor/neil are ok with it.
Keywords: helpwanted
IIRC it predates M14 so it's long overdue for removal ;-)
Yeah, looks safe to kill!
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
URL: http://mxr.mozilla.org/comm-central/s...
Severity: normal → trivial
Depends on: 487370
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.2a1
Untested, but trivial.
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #372634 - Flags: review?(mnyromyr)
Attached patch (Bv1) DOMi (obsolete) — — Splinter Review 
Untested, but trivial.
Attachment #372637 - Flags: review?(sdwilsh)
Keywords: helpwanted
Attachment #372637 - Attachment is obsolete: true
Attachment #372637 - Flags: review?(sdwilsh)
Comment on attachment 372637 [details] [diff] [review]
(Bv1) DOMi

Somebody else already filed a bug for this, and has a patch up with review in bug 488297.
Depends on: 488297
Comment on attachment 372832 [details] [diff] [review]
(Bv2) DOMi, whitespace cleanup only
[Checkin: Comment 9]

rs=sdwilsh
Attachment #372832 - Flags: review?(sdwilsh)
Comment on attachment 372832 [details] [diff] [review]
(Bv2) DOMi, whitespace cleanup only
[Checkin: Comment 9]


http://hg.mozilla.org/dom-inspector/rev/a212090d8f7e
Attachment #372832 - Attachment description: (Bv2) DOMi, whitespace cleanup only → (Bv2) DOMi, whitespace cleanup only [Checkin: Comment 9]
Attachment #372634 - Flags: review?(mnyromyr) → review+
Comment on attachment 372634 [details] [diff] [review]
(Av1-CC) /suite/*
[Checkin: Comment 10]


http://hg.mozilla.org/comm-central/rev/40efa12a940f
Attachment #372634 - Attachment description: (Av1-CC) /suite/* → (Av1-CC) /suite/* [Checkin: Comment 10]
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: