Legacy XUL attribute 'xulkey'

RESOLVED FIXED in mozilla1.9.2a1

Status

()

Core
XUL
--
trivial
RESOLVED FIXED
13 years ago
9 years ago

People

(Reporter: Karsten Düsterloh, Assigned: sgautherie)

Tracking

Trunk
mozilla1.9.2a1
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

13 years ago
Many <key>s in all products/projects still set an attribute 'xulkey', to various values like 'true', 'false', 'meta' or 'ctrl'. But LXR suggests that this attribute isn't used neither in any CSS nor is it processed by any backend code (anymore): <http://lxr.mozilla.org/mozilla/search?string=xulkey>

Since having an unused/unsupported, undocumented attribute is quite confusing, it should be removed.
Sounds fine, if mconnor/neil are ok with it.
Keywords: helpwanted

Comment 2

13 years ago
IIRC it predates M14 so it's long overdue for removal ;-)
Yeah, looks safe to kill!

Updated

10 years ago
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
(Assignee)

Updated

9 years ago
Severity: normal → trivial
Depends on: 487370
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.2a1
(Assignee)

Comment 4

9 years ago
Created attachment 372634 [details] [diff] [review]
(Av1-CC) /suite/*
[Checkin: Comment 10]

Untested, but trivial.
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #372634 - Flags: review?(mnyromyr)
(Assignee)

Comment 5

9 years ago
Created attachment 372637 [details] [diff] [review]
(Bv1) DOMi

Untested, but trivial.
Attachment #372637 - Flags: review?(sdwilsh)
(Assignee)

Updated

9 years ago
Keywords: helpwanted

Updated

9 years ago
Attachment #372637 - Attachment is obsolete: true
Attachment #372637 - Flags: review?(sdwilsh)
Comment on attachment 372637 [details] [diff] [review]
(Bv1) DOMi

Somebody else already filed a bug for this, and has a patch up with review in bug 488297.
(Assignee)

Updated

9 years ago
Depends on: 488297
(Assignee)

Comment 7

9 years ago
Created attachment 372832 [details] [diff] [review]
(Bv2) DOMi, whitespace cleanup only
[Checkin: Comment 9]
Attachment #372832 - Flags: review?(sdwilsh)
Comment on attachment 372832 [details] [diff] [review]
(Bv2) DOMi, whitespace cleanup only
[Checkin: Comment 9]

rs=sdwilsh
Attachment #372832 - Flags: review?(sdwilsh)
(Assignee)

Comment 9

9 years ago
Comment on attachment 372832 [details] [diff] [review]
(Bv2) DOMi, whitespace cleanup only
[Checkin: Comment 9]


http://hg.mozilla.org/dom-inspector/rev/a212090d8f7e
Attachment #372832 - Attachment description: (Bv2) DOMi, whitespace cleanup only → (Bv2) DOMi, whitespace cleanup only [Checkin: Comment 9]
(Reporter)

Updated

9 years ago
Attachment #372634 - Flags: review?(mnyromyr) → review+
(Assignee)

Comment 10

9 years ago
Comment on attachment 372634 [details] [diff] [review]
(Av1-CC) /suite/*
[Checkin: Comment 10]


http://hg.mozilla.org/comm-central/rev/40efa12a940f
Attachment #372634 - Attachment description: (Av1-CC) /suite/* → (Av1-CC) /suite/* [Checkin: Comment 10]
(Assignee)

Updated

9 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.