321960 - nsPluginInstanceOwner::GetUniqueID not-so-unique on 64-bit platforms

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Plug-ins, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

2267 NS_IMETHODIMP nsPluginInstanceOwner::GetUniqueID(PRUint32 *result)
2268 {
2269   NS_ENSURE_ARG_POINTER(result);
2270   *result = NS_PTR_TO_INT32(mOwner);

This may not be unique on 64-bit platforms. Maybe it should somehow include the upper 32 bit in the number.

Comment 1

[Jesse Ruderman]

You can't squeeze 64 bits into 32 bits.  Either the "unique ID" has to be calculated in a way other than from the pointer, or the API has to change (at least on 64-bit platforms).

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

We could simply keep a member that is set from a counter on each nsPluginInstaceOwner creation.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

the API can't change, it is part of the XPCOM plugin API.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Should we perhaps actually freeze the XPCOM plug-in API if it's effectively frozen?

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

it's marked deprecated, doesn't that imply frozen?

Comment 6

[Boris Zbarsky [:bzbarsky]]

Hmm.. I guess so.  Too bad people have no plans to stop using it.  :(

Comment 7

[Benjamin Smedberg]

This method/variable doesn't exist any more.