Closed Bug 322106 Opened 15 years ago Closed 15 years ago
Subframe and redirected URLs stay "hidden" permanently in history
If a URL is first visited as part of a redirection or as a subframe, the URI gets marked as hidden in history. If the URI is later visited as a top-level page without a redirect, it stays hidden (unless the user happens to type it explicitly in the URL bar). It seems that history should unhide any hidden URI if it is top-level and without redirect.
this is mostly just moving stuff around.
Attachment #207398 - Flags: review?(cbiesinger)
WFM Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060102 Firefox/1.6a1. I might not be testing the same way you tested, though.
I see the bug with a Dec 17 firefox CVS trunk build My test was 1. set up a server-side redirect for foo.html => bar.html 2. visit foo.html (not by typing the URI into the location bar) ==> foo.html should not show up in history 3. disable server-side redirection 4. visit foo.html (not by typing the URI) ==> foo.html should show up in history but does not That situation is not uncommon with sites the do cookie redirection madness. If you type in the foo.html URI, it will always show up. Based on the code, the same thing should happen with frames but I haven't tested it.
Comment on attachment 207398 [details] [diff] [review] patch r=biesi, sorry for taking so long :(
Attachment #207398 - Flags: review?(cbiesinger) → review+
Attachment #207398 - Flags: superreview?(neil) → superreview-
updated to address review comments
Attachment #210741 - Flags: superreview?(neil) → superreview+
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Attachment #210741 - Flags: approval-branch-1.8.1?(neil)
Attachment #210741 - Flags: approval-branch-1.8.1?(neil) → approval-branch-1.8.1+
You need to log in before you can comment on or make changes to this bug.