32220 - checksetup.pl script gives bad permissions

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect, P3)

Description

[Seth Landsman]

So the --CHMOD-- section in checksetup.pl is a little overzealous. 
Specifically, it chmod's everything, including directories, which makes
directories like contrib and CVS inaccessable.  See attached diff.

Comment 1

[Seth Landsman]

Attachment: Fix for checksetup.pl

Comment 2

[Terry Weissman]

[e-mail] is the new owner of Bugzilla and Bonsai.  (For details,
see my posting in netscape.public.mozilla.webtools,
news://news.mozilla.org/38F5D90D.F40E8C1A%40geocast.com .)

Comment 3

[Andreas Franke (gone)]

Just to touch it again: This bug has been created together with an attached fix 
on 3/17, and it's been sitting here untouched for more than two months now.

Comment 4

[Dave Miller [:justdave]]

Here's another patch for a problem I keep running into constantly and I hear 
other people mentioning it on the newsgroup all the time.  The patch has been 
sitting here since 3/17 and hasn't been checked in yet.  Basically, without this 
patch installed, bug submission via email breaks every time you run 
checksetup.pl, requiring manual chmodding of several directories and files to get 
it working again.

Comment 5

[Dave Miller [:justdave]]

Now that I can check things in, I'm taking care of this so those of us that use 
bug_email can stop having to re-do the permissions every freaking time we run 
checksetup.pl :)

Comment 6

[Dave Miller [:justdave]]

I ended up making some changes to your patch...  tightened up the code just a 
little.  Also, I moved the chown call outside of the file loop, since it was 
acting on glob('*') every time through the loop. :)

It's checked in now.

Comment 7

[Dave Miller [:justdave]]

In search of accurate queries....  (sorry for the spam)

Comment 8

[Gervase Markham [:gerv]]

Can someone CCed on this bug fix the --CHMOD-- section to allow the webserver 
write access to the new graphs directory?

Gerv

Comment 9

[Dave Miller [:justdave]]

Gerv, file a new bug for that. :)  There's been other CHMOD-related patches to 
checksetup.pl since the one on this bug (the one with the list of executable 
files comes to mind).

Comment 10

[Stephan Niemz]

*** Bug 72064 has been marked as a duplicate of this bug. ***

Comment 11

[Dave Miller [:justdave]]

Moving closed bugs to Bugzilla product