Missing accesskeys in the account wizard.

RESOLVED FIXED in seamonkey2.0a3

Status

--
minor
RESOLVED FIXED
13 years ago
10 years ago

People

(Reporter: vhaarr+bmo, Assigned: wladow)

Tracking

(Blocks: 1 bug)

Trunk
seamonkey2.0a3

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

13 years ago
The following items in the account wizard could use accesskeys:

    Account Wizard/
      New Account Setup (page 1)/
        "Unix Mailspool (Movemail)" optionbox.
      Server Information (page 3)/
        "Use Global Inbox (store mail in Local Folders)" chechbox.
      Congratulations (last page)/
        "Finish"-button (or is it activated by Return?)
(Assignee)

Comment 1

10 years ago
Created attachment 354060 [details] [diff] [review]
add accesskey, v1

>     Account Wizard/
>       New Account Setup (page 1)/
>         "Unix Mailspool (Movemail)" optionbox.
fixed in bug 369159
>       Server Information (page 3)/
>         "Use Global Inbox (store mail in Local Folders)" chechbox.
fixed in this patch

>       Congratulations (last page)/
>         "Finish"-button (or is it activated by Return?)
this needs toolkit patch
Assignee: mail → wladow
Status: NEW → ASSIGNED
Attachment #354060 - Flags: review?(philringnalda)
Created attachment 354131 [details] [diff] [review]
perhaps wrapped like so?

Wow. What do you suppose the whitespace style of AccountWizard.xul is called, "Horrible Mishmash"? Counting the inventive "trailing space, wrap at a bit over 80 chars, then indent two spaces instead of lining up" you're replacing, I think there's nine different styles of wrapping in that file, at least six of which shouldn't exist.

Fortunately, there are non-whitespace issues I think I can use to do a patch (in another bug) which will also let me whack most of them, while removing such evil as class attributes that separate an undefined classname from a defined one with a comma (nice! why use just a space, like the entire rest of the planet?), <label class="label" when there isn't such a class, and a spew of style attributes mostly setting the same width as one of the few defined classes, but unless Neil objects I think I'd rather see the new style of the file be "wrap at 80 chars, minimizing the number of lines" rather than "one attribute per line."

Oh, and as to your bug, instead of my bug-to-be: "r=me, thanks for the patch!" ;)
Attachment #354060 - Attachment is obsolete: true
Attachment #354131 - Flags: superreview?(neil)
Attachment #354131 - Flags: review+
Attachment #354060 - Flags: review?(philringnalda)
QA Contact: mailnews-account

Comment 3

10 years ago
Comment on attachment 354131 [details] [diff] [review]
perhaps wrapped like so?

>+<!ENTITY deferStorage.accesskey "U">
CAn I have a "G" please Bob?
Attachment #354131 - Flags: superreview?(neil) → superreview+
(Assignee)

Comment 4

10 years ago
Created attachment 355010 [details] [diff] [review]
for checkin
[Checkin: Comment 5]

Nicely wrapped G-patch ;)
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
Comment on attachment 355010 [details] [diff] [review]
for checkin
[Checkin: Comment 5]

http://hg.mozilla.org/comm-central/rev/fb30ab5bc3bf
Attachment #355010 - Attachment description: for checkin → for checkin [Checkin: Comment 5]
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Depends on: 369159
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0a3
(In reply to comment #1)
> >       Congratulations (last page)/
> >         "Finish"-button (or is it activated by Return?)
> this needs toolkit patch

Ah... You may want to file a separate bug or reopen this one.

Updated

10 years ago
No longer depends on: 369159
(Assignee)

Comment 7

10 years ago
(In reply to comment #6)
> Ah... You may want to file a separate bug or reopen this one.
That's bug 465607, although I'm not sure we can get it fixed in 1.9.1 due to string freeze already in effect.
You need to log in before you can comment on or make changes to this bug.