32239 - rebuildcvshistory fails on files whose rlog date are in mm/dd/yyyy format.

Status: RESOLVED FIXED

(Webtools Graveyard :: Bonsai, defect, P3)

Description

[Matthew G. Stahl]

rebuildcvshistory fails on files whose rlog date are in mm/dd/yyyy format.

Output from command:

Rebuilding entire checkin history in Bridge, (`Bridge' tree) ...
Doing directories: bridge ...
/home/cms/local/cvsroot/bridge/bin/1st,v
Use of uninitialized value at
        /opt/mozilla/webtools/bonsai/rebuildcvshistory.cgi line 115,  chunk 29 
(#1)
    
    (W) An undefined value was used as if it were already defined.  It was
    interpreted as a "" or a 0, but maybe it was a mistake.  To suppress this
    warning assign an initial value to your variables.

Synopsis:

Line 112 attempts to convert dates in yyyy/mm/dd format to mm/dd/yyyy format. 
However, if the date is already in the mm/dd/yyyy format, line 112 converts it 
to dd/yyyy/mm, which is not a valid date, so str2time returns a null date.

Proposed Revision:

# diff rebuildcvshistory.cgi /opt/mozilla/webtools/bonsai/rebuildcvshistory.cgi
1c1
> #!/usr/local/bin/perl -w
112c112
<                                    $datestr =~ s!^(\d+)/(\d+/\d+)!$2/$1!;
---
>                                    $datestr =~ s!^(\d{4})/(\d+/\d+)!$2/$1!;

This solved the issue on our system

Comment 1

[Terry Weissman]

[e-mail] is the new owner of Bugzilla and Bonsai.  (For details,
see my posting in netscape.public.mozilla.webtools,
news://news.mozilla.org/38F5D90D.F40E8C1A%40geocast.com .)

Comment 2

[Gervase Markham [:gerv]]

This bug has not been touched for more than nine months. In most cases, that 
means it has "slipped through the net". Please could the owner take a moment to 
add a comment to the bug with current status, and/or close it.

Thank you :-)

Gerv

Comment 3

[timeless]

Attachment: suggested patch

Comment 4

[timeless]

checked in