sliding alert (nsIAlertsService) should dismiss itself when clicked

RESOLVED FIXED

Status

()

Toolkit
XUL Widgets
--
trivial
RESOLVED FIXED
13 years ago
6 years ago

People

(Reporter: nrlz, Assigned: Nickolay_Ponomarev)

Tracking

({polish})

Trunk
x86
Windows XP
polish
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

13 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5

When the sliding alert appears (as a result of all downloads complete) it does not go away until it times-out. It therefore blocks the status bar for a longer period of time than is necessary.

I propose that clicking on it anywhere (body, or the link) should dismiss it.

Reproducible: Always

Steps to Reproduce:
1. Go to a site with popup windows.
2. At the same time download a file and finish downloading it.
3. As the download finishes, the sliding alert appears.
4. At the same time, the popup blocker status bar icon also appears, but is hidden by the downloads alert.

Actual Results:  
Clicking the sliding alert does not dismiss it.

Expected Results:  
Clicking the sliding alert anywhere should dismiss the sliding alert immediately.
(Assignee)

Updated

13 years ago
Severity: minor → trivial
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: polish
Summary: Alert service (sliding alert) should dismiss itself when clicked to avoid blocking the status bar → sliding alert (nsIAlertsService) should dismiss itself when clicked
Version: unspecified → Trunk
(hmm, there isn't an appropriate toolkit component for this...)
(Assignee)

Comment 2

13 years ago
Created attachment 207954 [details] [diff] [review]
close the alert when clicked

This makes the alerts window close when clicked (even if the linkified text was clicked). This makes sense to me.
Assignee: nobody → asqueella
Status: NEW → ASSIGNED
Attachment #207954 - Flags: review?(mconnor)
(Assignee)

Updated

12 years ago
Attachment #207954 - Flags: ui-review?(beltzner)
Attachment #207954 - Flags: ui-review?(beltzner) → ui-review+
(Assignee)

Comment 3

11 years ago
Created attachment 277232 [details] [diff] [review]
close alert when clicked, unbitrotted
Attachment #207954 - Attachment is obsolete: true
Attachment #277232 - Flags: review?(gavin.sharp)
Attachment #207954 - Flags: review?(mconnor)
Comment on attachment 277232 [details] [diff] [review]
close alert when clicked, unbitrotted

I was afraid that pending timeouts would cause trouble after closeAlert() is called from the click handler, but I suppose window.close() should take care of those. It's not obvious that it will, though, trying to trace through nsGlobalWindow::Close()...
Attachment #277232 - Flags: review?(gavin.sharp) → review+
Is there any reason for this not to land?
(Assignee)

Comment 6

10 years ago
Oops, missed the r+.

Dave: it could land. I'm not sure when I'll get to checking if it still applies and unbitrotting if necessary, so if you could try to check this is for me, I'd appreciate it.
Seems good, landed in http://hg.mozilla.org/index.cgi/mozilla-central/rev/889e2e6df7c8
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1a2
Test please?
Flags: in-testsuite?

Updated

6 years ago
Component: General → XUL Widgets
Product: Firefox → Toolkit
Target Milestone: Firefox 3.1a2 → ---
You need to log in before you can comment on or make changes to this bug.