322712 - cannot export local attachments

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Frédéric Buclin]

When moving bugs to another installation, attachments stored in data/attachments/ are not correctly exported. Looks like they are truncated. Seems a problem with Attachment::data().

Comment 1

[Frédéric Buclin]

There is a missing "local $/;" in Attachment::data() when reading attachments stored in data/attachments. This truncates and corrupts them. That's what I call dataloss.

This method was introduced in bug 302669 which landed on 2.22 only.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Indeed, we need a "local $/;" statement before we read the data.

Frederic also asked me on IRC whether we really need "binmode".  As far as I can tell from my reading of the binmode and PerlIO documentation, yes, we do need "binmode," although there may be some circumstances in which we don't want it (f.e. when dealing with text attachments if we want line ending translation on Windows machines).

http://perldoc.perl.org/functions/binmode.html
http://perldoc.perl.org/PerlIO.html

Comment 3

[Frédéric Buclin]

Attachment: patch, v1

add local $/;

Comment 4

[Frédéric Buclin]

Checking in Bugzilla/Attachment.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Attachment.pm,v  <--  Attachment.pm
new revision: 1.30; previous revision: 1.29
done