322724 - Supported SVG Feature Strings are incorrect

Status: RESOLVED FIXED

(Core :: SVG, defect, P2)

Description

[Jeff Schiller]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5

http://www.codedread.com/svgtest.svg shows that Firefox 1.5 claims to support the feature string http://www.w3.org/TR/SVG11/feature#SVGDOM.  However, the SVG 1.1 Full spec (http://www.w3.org/TR/SVG11/feature.html) states that for #SVGDOM "At least one of the following must be supported:
"http://www.w3.org/TR/SVG11/feature#SVGDOM-static", "http://www.w3.org/TR/SVG11/feature#SVGDOM-animation" or "http://www.w3.org/TR/SVG11/feature#SVGDOM-dynamic"

But none of these is supported by Firefox 1.5.  For instance, SVGDOM-static must support all the DOM interfaces for the static features, but not all DOM interfaces are supported (for instance SVGPathElement::replaceItem() method).

Reproducible: Always



Expected Results:  
SVGDOM feature string should not be supported

Comment 1

[Jonathan Watt [:jwatt]]

We should properly re-audit all our feature strings.

Comment 2

[Brian Crowder]

jwatt:  Do you want to own this?

Drivers:  This isn't a regression, are we sure we want it to block?

Comment 3

[Damon Sicore (:damons)]

Nope.  -'ing.  If someone disagrees, feel free to give reasons why we should block.

Comment 5

[Robert Longson [:longsonr]]

Attachment: patch

I've been through them all and here's my take on it.

ContainerAttribute - unsupported as we don't support enable-background
Image          - unsupported as it doesn't work with svg images
PaintAttribute - unsupported as we don't support color-interpolation
Cursor         - unsupported as we don't implement cursor elements
org.w3c.svg    - unsupported because it's dependent on other unsupported features
org.w3c.svg.lang - removed as it doesn't exist!
org.w3c.dom.svg - unsupported because it's dependent on other unsupported features

Comment 6

[Jeff Schiller]

Robert, can you clarify what isn't supported in the BasicFilter module?

Comment 7

[Robert Longson [:longsonr]]

FilterPrimitiveWithIn.attrib we don't support all possible values of in.

in = "SourceGraphic | SourceAlpha | BackgroundImage | BackgroundAlpha  | FillPaint | StrokePaint | <filter-primitive-reference>"

and we only do SourceGraphic and SourceAlpha.

Comment 8

[Jonathan Watt [:jwatt]]

Comment on attachment 313082 [details] [diff] [review]
patch

Yup, looks good. r=jwatt

Comment 9

[Robert Longson [:longsonr]]

Comment on attachment 313082 [details] [diff] [review]
patch

Makes our feature strings more accurate, unless we completely support all aspects of a feature we mark it unsupported.

Comment 10

[Jonathan Watt [:jwatt]]

As far as I'm concerned this blocks. It's a standards compliance issue and we defeat the purpose of feature strings if they can't be relied upon. The fix is very safe, so let's ship it.

Comment 11

[Robert Longson [:longsonr]]

checked in.