322763 - Should be a UI for the administrator to view an account's history

Status: RESOLVED FIXED

(Webtools Graveyard :: Despot, defect, P3)

Description

[Dave Miller [:justdave]]

Despot records user account changes to a table in the database, but there's no UI for viewing it.

Comment 1

[Reed Loden [:reed]]

Attachment: patch - v1 (very barebones UI)

This is a patch for something I'm ashamed to call a UI. :(
It's ugly, shows everything as raw data, doesn't work if user has changed e-mail address, and doesn't convert voucher ids into e-mail addresses.

I had to modify ListSomething() slightly so I could get away with not having an [edit] button for every row.

Comment 2

[Dave Miller [:justdave]]

Comment on attachment 247646 [details] [diff] [review]
patch - v1 (very barebones UI)

>+    my $wherepart = "email = " . $::db->quote($F::email);;

too many semicolons ^^^

>+        if ($editprocname ne "") {

Just a perl hint here...  an empty string is counted as false for boolean comparisons.  So you can just do this:

if ($editprocname) {

and it'll do the right thing here.

Comment 3

[Dave Miller [:justdave]]

For the record, this is a good start, and better than nothing.  We can improve on the other stuff later.

Comment 4

[Reed Loden [:reed]]

Attachment: patch - v2

Addressed review comments.

Comment 5

[Reed Loden [:reed]]

Attachment: patch - v2 (second try)

Um, actually attach the new patch this time.

Comment 6

[Reed Loden [:reed]]

Checking in despot.cgi;
/cvsroot/mozilla/webtools/despot/despot.cgi,v  <--  despot.cgi
new revision: 1.50; previous revision: 1.49
done