Should be a UI for the administrator to view an account's history

RESOLVED FIXED

Status

Webtools Graveyard
Despot
P3
normal
RESOLVED FIXED
13 years ago
2 years ago

People

(Reporter: justdave, Assigned: reed)

Tracking

Details

Attachments

(1 attachment, 2 obsolete attachments)

Despot records user account changes to a table in the database, but there's no UI for viewing it.
Assignee: justdave → justdave
Priority: -- → P3
(Assignee)

Updated

12 years ago
QA Contact: timeless → despot
(Assignee)

Comment 1

12 years ago
Created attachment 247646 [details] [diff] [review]
patch - v1 (very barebones UI)

This is a patch for something I'm ashamed to call a UI. :(
It's ugly, shows everything as raw data, doesn't work if user has changed e-mail address, and doesn't convert voucher ids into e-mail addresses.

I had to modify ListSomething() slightly so I could get away with not having an [edit] button for every row.
Assignee: justdave → reed
Status: NEW → ASSIGNED
Attachment #247646 - Flags: review?(justdave)
Comment on attachment 247646 [details] [diff] [review]
patch - v1 (very barebones UI)

>+    my $wherepart = "email = " . $::db->quote($F::email);;

too many semicolons ^^^

>+        if ($editprocname ne "") {

Just a perl hint here...  an empty string is counted as false for boolean comparisons.  So you can just do this:

if ($editprocname) {

and it'll do the right thing here.
Attachment #247646 - Flags: review?(justdave) → review-
For the record, this is a good start, and better than nothing.  We can improve on the other stuff later.
(Assignee)

Comment 4

12 years ago
Created attachment 247647 [details] [diff] [review]
patch - v2

Addressed review comments.
Attachment #247646 - Attachment is obsolete: true
Attachment #247647 - Flags: review?(justdave)
(Assignee)

Comment 5

12 years ago
Created attachment 247648 [details] [diff] [review]
patch - v2 (second try)

Um, actually attach the new patch this time.
Attachment #247647 - Attachment is obsolete: true
Attachment #247648 - Flags: review?(justdave)
Attachment #247647 - Flags: review?(justdave)
Attachment #247648 - Flags: review?(justdave) → review+
(Assignee)

Comment 6

12 years ago
Checking in despot.cgi;
/cvsroot/mozilla/webtools/despot/despot.cgi,v  <--  despot.cgi
new revision: 1.50; previous revision: 1.49
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.