322877 - Freeze nsIStringInputStream

Status: RESOLVED WONTFIX

(Core :: XPCOM, enhancement)

Description

[Darin Fisher]

Now that we have nsIStringInputStream2, we should freeze nsIStringInputStream and add it to the Gecko SDK.

Comment 1

[Darin Fisher]

This task entails the following changes:

 * Move nsIStringInputStream out of nsIStringStream.idl and into its own IDL file named nsIStringInputStream.idl,
 * Move the ContractID defined in nsStringStream.h into nsXPCOMCID.h, and document the interface contract.
 * We should probably create nsIStringInputStream2.idl in the process.

If someone would like to volunteer to write such a patch, I'll volunteer a speedy code review ;-)

Comment 2

[timeless]

can we please deal w/ the data problems before freezing. if the conclusion is that the other data attribute needs to live on a non inheriting interface, or that it needs to be renamed or ...

note that this is my last plea. i'll be in Israel starting next week, and I'll return to the states Feb 1. I hope not to be disappointed when I return :(.

Comment 3

[Darin Fisher]

timeless: we can change nsIStringInputStream2 independently of whether or not we freeze nsIStringInputStream.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

(that's bug 324058 now)

Comment 5

[John Melton]

Attachment: Patch V1

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 235737 [details] [diff] [review]
Patch V1

John, you want to request review from a specific person.  See http://www.mozilla.org/owners.html for the module owners and peers for various modules.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 235737 [details] [diff] [review]
Patch V1

what did you do to camino/src/bookmarks/nsAboutBookmarks.mm?

extensions/metrics/src/nsMetricsService.cpp
 // We need to suppress inclusion of nsString.h
 #define nsString_h___

as a random note, I think this is no longer necessary

intl/uconv/src/nsScriptableUConv.cpp
+//#include "nsIStringStream.h"
+#include "nsIStringInputStream.h"

why the commented out line?

layout/generic/nsObjectFrame.cpp
+#include "nsIStringInputStream.h" // for NS_NewCharInputStream

sigh, the commented was outdated even before your change... if you remove this include, do things still compile?

modules/libpr0n/decoders/icon/mac/nsIconChannelCocoa.mm

hm, what are you doing to all the objc files? :)

xpcom/io/Makefile.in

hm, not limited to objc, clearly...

xpcom/io/nsIStringInputStream.idl
+// C++ factory methods

er... is this a branch patch? Why? This shouldn't land on branch IMO, and trunk is different here...

Comment 8

[John Melton]

Attachment: Patch V2

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 235813 [details] [diff] [review]
Patch V2

this is still a branch patch

Comment 10

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

We don't freeze interfaces anymore.