stack walking code incorrectly tries to detect NT and faills w/ old sdks

ASSIGNED
Assigned to

Status

()

Core
XPCOM
ASSIGNED
12 years ago
8 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

12 years ago
i was trying to use weirdals' vc6 build on his xp home laptop, and it didn't like things.
(Assignee)

Comment 1

12 years ago
Created attachment 208079 [details] [diff] [review]
properly detect NT
Assignee: dougt → timeless
Status: NEW → ASSIGNED
Attachment #208079 - Flags: review?(dougt)

Comment 2

12 years ago
Comment on attachment 208079 [details] [diff] [review]
properly detect NT

fix up the whitespace.

Is there a way you can use: 

http://lxr.mozilla.org/mozilla/source/xpcom/base/nsStackFrameWin.h#53
Attachment #208079 - Flags: review?(dougt)

Comment 3

12 years ago
Comment on attachment 208079 [details] [diff] [review]
properly detect NT

fix up the whitespace.

Is there a way you can use: 

http://lxr.mozilla.org/mozilla/source/xpcom/base/nsStackFrameWin.h#53

Comment 4

12 years ago
Comment on attachment 208079 [details] [diff] [review]
properly detect NT

fix up the whitespace.

Is there a way you can use: 

http://lxr.mozilla.org/mozilla/source/xpcom/base/nsStackFrameWin.h#53

Comment 5

12 years ago
Comment on attachment 208079 [details] [diff] [review]
properly detect NT

fix up the whitespace.

Is there a way you can use: 

http://lxr.mozilla.org/mozilla/source/xpcom/base/nsStackFrameWin.h#53

Comment 6

12 years ago
Comment on attachment 208079 [details] [diff] [review]
properly detect NT

fix up the whitespace.

Is there a way you can use: 

http://lxr.mozilla.org/mozilla/source/xpcom/base/nsStackFrameWin.h#53

Comment 7

12 years ago
Comment on attachment 208079 [details] [diff] [review]
properly detect NT

fix up the whitespace.

Is there a way you can use: 

http://lxr.mozilla.org/mozilla/source/xpcom/base/nsStackFrameWin.h#53

Comment 8

12 years ago
Comment on attachment 208079 [details] [diff] [review]
properly detect NT

fix up the whitespace.

Is there a way you can use: 

http://lxr.mozilla.org/mozilla/source/xpcom/base/nsStackFrameWin.h#53
(Assignee)

Comment 9

12 years ago
Created attachment 214145 [details] [diff] [review]
properly detect NT (no tabs)

um no. you can't use a compile time flag for a runtime problem.
Attachment #208079 - Attachment is obsolete: true
Attachment #214145 - Flags: review?(dougt)
Comment on attachment 214145 [details] [diff] [review]
properly detect NT (no tabs)

doesn't apply ( the code exists here: http://mxr.mozilla.org/mozilla-central/source/xpcom/base/nsStackWalk.cpp#934 )

You have to init the static osPlatform before testing for it.

Also, i do not think we care about this class of win32 machines any longer, right?
Attachment #214145 - Flags: review?(dougt) → review-
You need to log in before you can comment on or make changes to this bug.