[FIX]Add some more use of AttrValueIs to layout

RESOLVED FIXED in mozilla1.9alpha1

Status

()

P3
normal
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

Trunk
mozilla1.9alpha1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

13 years ago
This was sitting in my tree and I kinda want to get rid of it.
(Assignee)

Updated

13 years ago
Priority: -- → P3
Summary: Add some more use of AttrValueIs to layout → [FIX]Add some more use of AttrValueIs to layout
Target Milestone: --- → mozilla1.9alpha
(Assignee)

Comment 1

13 years ago
Created attachment 208093 [details] [diff] [review]
Patch
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #208093 - Flags: superreview?(roc)
Attachment #208093 - Flags: review?(roc)
Comment on attachment 208093 [details] [diff] [review]
Patch

yum
Attachment #208093 - Flags: superreview?(roc)
Attachment #208093 - Flags: superreview+
Attachment #208093 - Flags: review?(roc)
Attachment #208093 - Flags: review+
(Assignee)

Comment 3

13 years ago
Created attachment 208107 [details] [diff] [review]
Forgot this file

Needed to not break the build
(Assignee)

Comment 4

13 years ago
Fixed.  mZ went down by 2900.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Comment 5

13 years ago
Wasn't there some RFE somewhere for an interface to AttrValueIs on XULElement?
(Assignee)

Comment 6

13 years ago
Not sure.  AttrValueIs on nsIContent (what I'm using here) is pretty recent (trunk-only).

Comment 7

13 years ago
Well, maybe not that specific interface then... the use case is all the return this.getAttribute("disabled") == "true"; type tests used heavily in XBL.
(Assignee)

Comment 8

13 years ago
Oh, a DOM accessible API.  Yeah, I guess we could do it.  But most of the benefits of the nsIContent AttrValueIs (eg atom compares) would be lost.
You need to log in before you can comment on or make changes to this bug.