322971 - Bogus return in XPCNativeWrapper

Status: RESOLVED FIXED

(Core :: XPConnect, defect, P1)

Description

[Blake Kaplan (:mrbkap) (inactive)]

Viz,

JS_STATIC_DLL_CALLBACK(JSBool)
XPC_NW_Construct(JSContext *cx, JSObject *obj, uintN argc, jsval *argv,
...
  if (JSVAL_IS_PRIMITIVE(*rval)) {
    return NS_ERROR_ILLEGAL_VALUE;

I think all of our constructors are well-behaved enough that this probably doesn't bite us, not to mention that the primitive value will get turned into a normal object by the engine, but it's bad hygiene and karma and all that.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

Comment 2

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 208119 [details] [diff] [review]
Fix

r+sr+omgthx=shaver

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Fix'd. D'oh.