322973 - Update talkback symbol update process to use SSH2

Status: RESOLVED FIXED

(Core Graveyard :: Talkback Client, defect)

Description

[Chris Cooper [:coop] (he/him)]

We're looking to do away with SSH1 on all build system machines. One aspect of this transition is to ensure that talkback uses SSH2 for symbol upload.

I've already got a patch here. I'll attach it shortly.

Comment 1

[Chris Cooper [:coop] (he/him)]

Attachment: Set SSH_VERSION, and then use that for each following ssh command

Comment 2

[Chase Phillips]

Comment on attachment 208123 [details] [diff] [review]
Set SSH_VERSION, and then use that for each following ssh command

I recommend you use two separate variables for these versions, one for each of the two sets of SSH connections.

Comment 3

[Chris Cooper [:coop] (he/him)]

Attachment: Use separate SSH_VERSION variables for the FC and SYM connections

Comment 4

[Chase Phillips]

Comment on attachment 208136 [details] [diff] [review]
Use separate SSH_VERSION variables for the FC and SYM connections

Looks good.

Comment 5

[Chris Cooper [:coop] (he/him)]

Checking in Makefile.in;
/mofo/talkback/fullsoft/Makefile.in,v  <--  Makefile.in
new revision: 1.59; previous revision: 1.58
done

I'll leave this open for a day or so while I verify that talkback is continuing to upload symbols as expected.

Comment 6

[Chris Cooper [:coop] (he/him)]

All the affected systems appear to be uploading their talkback symbols normally.

Comment 7

[Chase Phillips]

These changes need to be ported to the other 5 branches, as well:

 * MOZILLA_1_7_BRANCH
 * MOZILLA_1_8_BRANCH
 * MOZILLA_1_8_0_BRANCH
 * AVIARY_1_0_20040515_BRANCH
 * AVIARY_1_0_1_20050124_BRANCH

Comment 8

[Chris Cooper [:coop] (he/him)]

(In reply to comment #7)
> These changes need to be ported to the other 5 branches, as well:
> 
>  * MOZILLA_1_7_BRANCH
>  * MOZILLA_1_8_BRANCH
>  * MOZILLA_1_8_0_BRANCH
>  * AVIARY_1_0_20040515_BRANCH
>  * AVIARY_1_0_1_20050124_BRANCH
> 

All these branches have been updated now too.