Migration Integration Audit

RESOLVED FIXED

Status

()

Firefox
Bookmarks & History
P1
blocker
RESOLVED FIXED
13 years ago
9 years ago

People

(Reporter: Ben Goodger (use ben at mozilla dot org for email), Assigned: Annie Sullivan)

Tracking

({fixed1.8.1})

Trunk
fixed1.8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Look at the code that imports from other browsers and update it to use the new Bookmarks/History APIs if necessary using #ifdef MOZ_PLACES for now. Test import from various browsers in the following cases:

"warm import" into an existing Firefox profile
"cold import" (move aside all your firefox profiles, then run firefox invoking auto-import)

There is quite a test matrix here, just look at all the migrators!
Severity: normal → blocker
Priority: -- → P1
(Assignee)

Comment 1

13 years ago
Created attachment 209500 [details] [diff] [review]
Uses new bookmarks service for Migration

I've tested this on Windows with Opera 8.5, IE 6.0, and Netscape 4.8.  Will test on Mac w/Safari before checking in.
Attachment #209500 - Flags: review?(bugs)
(Assignee)

Comment 2

13 years ago
Created attachment 209649 [details] [diff] [review]
Fixes typo in safari migrator and includes missing idl file
Attachment #209500 - Attachment is obsolete: true
Attachment #209649 - Flags: review?(bugs)
Attachment #209500 - Flags: review?(bugs)
Comment on attachment 209649 [details] [diff] [review]
Fixes typo in safari migrator and includes missing idl file

r=ben@mozilla.org
Attachment #209649 - Flags: review?(bugs) → review+
(Assignee)

Updated

13 years ago
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Comment 4

13 years ago
For 1.8branch, NS_ConvertUTF8toUTF16 shouldn't have been used. keyNameStr comes from a Windows 'A' API so that NS_CopyNativeToUnicode should be used instead. 
(Perhaps, we have to add this point to our string document)

#ifdef MOZ_PLACES
          bms->InsertItem(keywordsFolder, uri, -1);
          bms->SetItemTitle(uri, NS_ConvertUTF8toUTF16(keyNameStr));
#else

This point got moot by 'migrating' the migrator code to use nsWindowsRegkey in bug 250255, but I thought it might be a good idea to note that  here to minimize the number of similar mistakes in the future. 
Keywords: fixed1.8.1
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.