322996 - Enable IDN for .is domain

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Gervase Markham [:gerv]]

We need to enable IDN for the .is (Iceland) domain.
Policy: http://www.isnic.is/english/domain/rules.php (section 1.1.1)

Gerv

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Here's the patch. Policy change rather than code change of any significance, so review not needed (by precedent).

Gerv

Comment 2

[Reed Loden [:reed]]

gerv requests that this be checked-in by somebody as soon as it has the necessary approvals.

Comment 3

[Mike Schroepfer]

Comment on attachment 208151 [details] [diff] [review]
Patch v.1

Please land on trunk first - which means this change can't really make this branch until the 1.8.0.2 (I've already nominated it for that branch).

Comment 4

[:Gavin Sharp [email: [e-mail]]]

This is a policy decision, it just involves adding the TLD to the "accept" list: it's not something that will cause regressions, so trunk baking time won't make a difference.

Comment 5

[Reed Loden [:reed]]

(In reply to comment #3)
> (From update of attachment 208151 [details] [diff] [review] [edit])
> Please land on trunk first - which means this change can't really make this
> branch until the 1.8.0.2 (I've already nominated it for that branch).   

Why does it have to be landed on the trunk first? This statement has no precedent for policy changes such as this. Other policy change bugs dealing with IDN (such as bug 308334 and bug 313490) were checked into the trunk and branch at the same time. I don't see why this bug cannot be the same way.

Comment 6

[Mike Schroepfer]

Comment on attachment 208151 [details] [diff] [review]
Patch v.1

Since we allowed this without backing (bug 308334  - thanks Reed) we should do so here.

Even though it's a policy decision it is being implemented in code.  Typos in all.js could cause other problems (although this change is trivial to inspect).  1.8.0.1 is automatically given to users - hence a little paranoia about quality.  :-)

Comment 7

[Mike Schroepfer]

Forgot to ask that it be landed on trunk, 1.8, and 1.8.0 branches.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Landed on the 1.8 and 1.8.0 branches.
mozilla/modules/libpref/src/init/all.js; new revision: 3.585.2.19;
mozilla/modules/libpref/src/init/all.js; new revision: 3.585.2.17.2.2;

Comment 9

[:Gavin Sharp [email: [e-mail]]]

And on the trunk.
mozilla/modules/libpref/src/init/all.js; new revision: 3.619;

Comment 10

[Gervase Markham [:gerv]]

Gavin, Reed, Mike: thanks for helping this squeeze in under the wire :-)

Gerv