323056 - Link to "parent directory" displayed for top-level FTP sites

Status: RESOLVED WONTFIX

(Core Graveyard :: Networking: FTP, defect)

Description

[Jeff Walden [:Waldo]]

The directory listing code specifically tries to not show a link to a parent directory when none exists; this works for <file:///> but doesn't work for ftp links.  Consequently, if I start at any valid directory listing within ftp.mozilla.org, I can click on links displayed on the page and eventually reach a page like <ftp://ftp.mozilla.org/../../../../../../>.  This should not be possible.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Patch

It's not clear to me why the path could be "//" or "/%2F" during normal FTP browsing, but I assume there's a valid reason for it, so I just added one more check to make sure the path isn't "/".

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 208211 [details] [diff] [review]
Patch

good find jeff. sorry for the delay.

Comment 3

[Patrick McManus [:mcmanus]]

We are in a period where ftp is clearly deprecated and in general, making changes to the code is riskier than letting it ride unless there is a patch and reviewer available to make a good judgment about it. So I'm going to wontfix ftp bugs related to enhancements, interop errors, etc.. We will be better off putting our energy into including a different js based ftp stack.