Closed
Bug 323056
Opened 19 years ago
Closed 8 years ago
Link to "parent directory" displayed for top-level FTP sites
Categories
(Core Graveyard :: Networking: FTP, defect)
Core Graveyard
Networking: FTP
Tracking
(Not tracked)
RESOLVED
WONTFIX
mozilla1.9alpha1
People
(Reporter: Waldo, Assigned: Waldo)
References
()
Details
Attachments
(1 file)
1.52 KB,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
The directory listing code specifically tries to not show a link to a parent directory when none exists; this works for <file:///> but doesn't work for ftp links. Consequently, if I start at any valid directory listing within ftp.mozilla.org, I can click on links displayed on the page and eventually reach a page like <ftp://ftp.mozilla.org/../../../../../../>. This should not be possible.
Assignee | ||
Comment 1•19 years ago
|
||
It's not clear to me why the path could be "//" or "/%2F" during normal FTP browsing, but I assume there's a valid reason for it, so I just added one more check to make sure the path isn't "/".
Attachment #208211 -
Flags: review?
Assignee | ||
Updated•19 years ago
|
Attachment #208211 -
Flags: review? → review?(dougt)
Updated•15 years ago
|
Attachment #208211 -
Flags: review?(doug.turner) → review+
Comment 2•15 years ago
|
||
Comment on attachment 208211 [details] [diff] [review] Patch good find jeff. sorry for the delay.
Comment 3•8 years ago
|
||
We are in a period where ftp is clearly deprecated and in general, making changes to the code is riskier than letting it ride unless there is a patch and reviewer available to make a good judgment about it. So I'm going to wontfix ftp bugs related to enhancements, interop errors, etc.. We will be better off putting our energy into including a different js based ftp stack.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
Updated•2 months ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•