All users were logged out of Bugzilla on October 13th, 2018
Bug 316076, attachment 207350 [details] [diff] [review], modified the following two files to contain app-specific ifdefs (MOZ_MACBROWSER): layout/forms/nsComboboxControlFrame.cpp widget/src/cocoa/nsCocoaWindow.mm These are to work around Camino's context menu hacks. If we are to produce a xulrunner binary that will support Camino and other Cocoa widget consumers, we need to turn those ifdefs into a pref. Or we could remove the Camino context menu hacks :)
Created attachment 259778 [details] [diff] [review] fix v1.0 I'm certainly open to suggestions for a better name for the pref.
Attachment #259778 - Flags: review?(stuart.morgan)
Comment on attachment 259778 [details] [diff] [review] fix v1.0 Making widget depend on prefs seems a bit sketchy, but since I don't have any better suggestions, r=smorgan. I do think we should remove at least the <select> menu hack, but I'd really like to see about making them look native first. Is there a bug tracking making them look and act like the contextual menus?
Attachment #259778 - Flags: review?(stuart.morgan) → review+
Attachment #259778 - Flags: superreview?(benjamin) → superreview+
fixed on trunk
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.