deleted attachment: "Deleted: " not localizable

NEW
Assigned to

Status

MailNews Core
Internationalization
12 years ago
5 years ago

People

(Reporter: Jason Haar, Assigned: smontagu)

Tracking

(Blocks: 1 bug, {intl})

unspecified
Dependency tree / graph
Bug Flags:
blocking-thunderbird2 -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 obsolete attachment)

(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20051111 Firefox/1.5

When you delete an attachment, Thunderbird 1.5 replaces the attachment with MIME code like:

Content-Type: text/x-moz-deleted; name="Deleted: tibs-rescue.iso"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline; filename="Deleted:tibs-rescue.iso"
X-Mozilla-Altered: AttachmentDeleted; date="Mon Nov 21 10:45:27 2005"


There's a slight mistake there: "Deleted: " vs "Deleted:"

Maybe that filename should be created as a variable first and then used for both lines? 

Our AV triggers on that due to it looking like an attempt to pass an attachment through with different filenames...

Reproducible: Always

Comment 1

12 years ago
-> new, there is a missing space there.
Also, the string is not localizable (but the string for it is already in messenger.properties). Patch coming up.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Summary: deleted attachment feature created incorrect MIME messages → deleted attachment: "Deleted: " vs "Deleted:", not localizable

Comment 2

12 years ago
Created attachment 210044 [details] [diff] [review]
proposed fix
Attachment #210044 - Flags: review?(bienvenu)

Comment 3

12 years ago
Comment on attachment 210044 [details] [diff] [review]
proposed fix

I'm not sure that just sticking a utf8 string in a  content type name field is the right thing to do. Maybe it is, but cc'ing jshin
Attachment #210044 - Flags: superreview?(bienvenu)
Attachment #210044 - Flags: review?(jshin1987)
Attachment #210044 - Flags: review?(bienvenu)

Comment 4

12 years ago
Comment on attachment 210044 [details] [diff] [review]
proposed fix

Sorry I missed this. 

> (From update of attachment 210044 [details] [diff] [review] [edit])
> I'm not sure that just sticking a utf8 string in a  content type name field is
> the right thing to do. Maybe it is, but cc'ing jshin

Per the *current* mail standard, we should use RFC 2231. The function to use is RFC2231ParmFolding at 
http://lxr.mozilla.org/seamonkey/source/mailnews/compose/src/nsMsgCompUtils.cpp#1235

It's a static function so that we have to move it somewhere else.
Attachment #210044 - Flags: review?(jshin1987)

Updated

12 years ago
Attachment #210044 - Flags: superreview?(bienvenu)

Comment 5

12 years ago
I guess this depends on bug 295084 then...
Depends on: 295084

Comment 6

12 years ago
The string is still not localizable and attachmentDeletePrefix from messenger.properties still not used. Added l10n@mozilla.com to CC.

Comment 7

11 years ago
(In reply to comment #1 and commnet #6)
blocking‑thunderbird2=?
Flags: blocking-thunderbird2?

Comment 8

11 years ago
Moving off bugs that didn't make the deadline for Thunderbird 2. 
Flags: blocking-thunderbird2? → blocking-thunderbird2-
Target Milestone: --- → Thunderbird 3
QA Contact: front-end

Updated

10 years ago
Assignee: mscott → mkmelin+mozilla

Updated

10 years ago
Duplicate of this bug: 303443

Updated

9 years ago
Attachment #210044 - Attachment is obsolete: true

Comment 10

9 years ago
The space after "Deleted:" was added in bug 329915. 
Making it localizable is more work than I'd like to spend on this, so ->defaults
Assignee: mkmelin+mozilla → smontagu
Component: Mail Window Front End → Internationalization
Keywords: intl
Product: Thunderbird → MailNews Core
QA Contact: front-end → i18n
Hardware: x86 → All
Summary: deleted attachment: "Deleted: " vs "Deleted:", not localizable → deleted attachment: "Deleted: " not localizable
Target Milestone: Thunderbird 3 → ---

Updated

8 years ago
Duplicate of this bug: 553898

Comment 12

8 years ago
Another unlocalizable string next to it:
"You deleted an attachment from this message. The original MIME headers for the attachment were:"

Comment 13

8 years ago
Jesper, can you file a bug for this...
> Another unlocalizable string next to it:
> "You deleted an attachment from this message. The original MIME headers for the
> attachment were:"

Comment 14

8 years ago
(In reply to comment #13)
> Jesper, can you file a bug for this...

Isn't this the bug?
Simon Montagu (assignee), are you still working on this?
Otherwise, please assign to nobody.
You need to log in before you can comment on or make changes to this bug.