32320 - MLK: png images leak!

Status: VERIFIED FIXED

(Core :: Graphics: ImageLib, defect, P2)

Description

[Bruce Mitchener]

Visit http://www.w3c.org/ and PNG images leak.  I did this in viewer with 
today's build: viewer -url http://www.w3c.org/

The trace below is not the only thing that leaks by any means, but it is 
representative (except in size).

MLK: 1524 bytes leaked in 3 blocks
  * This memory was allocated from:
        malloc         [rtlib.o]
        png_create_struct [pngmem.c:322]
        png_create_read_struct [pngread.c:45]
        il_png_write(il_container_struct*,const unsigned char*,int) 
[ipng.cpp:90]
        PNGDecoder::ImgDWrite(const unsigned char*,int) [nsPNGDecoder.cpp:106]
        IL_StreamWrite(il_container_struct*,const unsigned char*,int) 
[if.cpp:1002]
        NetReaderImpl::Write(const unsigned char*,int) [ilNetReader.cpp:100]
        
ImageConsumer::OnDataAvailable(nsIChannel*,nsISupports*,nsIInputStream*,unsigned 
int,unsigned int) [nsImageNetContextAsync.cpp:389]
        
nsDocumentOpenInfo::OnDataAvailable(nsIChannel*,nsISupports*,nsIInputStream*,uns
igned int,unsigned int) [nsURILoader.cpp:267]
        
InterceptStreamListener::OnDataAvailable(nsIChannel*,nsISupports*,nsIInputStream
*,unsigned int,unsigned int) [nsCachedNetData.cpp:1128]
        
nsHTTPServerListener::OnDataAvailable(nsIChannel*,nsISupports*,nsIInputStream*,u
nsigned int,unsigned int) [nsHTTPResponseListener.cpp:375]
        nsOnDataAvailableEvent::HandleEvent() [nsAsyncStreamListener.cpp:384]
        nsStreamListenerEvent::HandlePLEvent(PLEvent*) 
[nsAsyncStreamListener.cpp:97]
        PL_HandleEvent [plevent.c:563]
        PL_ProcessPendingEvents [plevent.c:508]
        nsEventQueueImpl::ProcessPendingEvents() [nsEventQueue.cpp:314]
        event_processor_callback(void*,int,GdkInputCondition) 
[nsAppShell.cpp:141]
        our_gdk_io_invoke(_GIOChannel*,GIOCondition,void*) [nsAppShell.cpp:54]
        g_io_unix_dispatch [giounix.c:131]
        g_main_dispatch [gmain.c:647]
        g_main_iterate [gmain.c:854]
        g_main_run     [gmain.c:912]
        gtk_main       [gtkmain.c:475]
        nsAppShell::Run() [nsAppShell.cpp:303]
        nsNativeViewerApp::Run() [nsGtkMain.cpp:55]
        main           [nsGtkMain.cpp:173]
        _start         [crt1.o]
  * Block of 508 bytes (3 times); last block at 0xda5f60

Comment 1

[neeti]

Changing to priority to P2.

Comment 2

[pnunn]

Attachment: fix for leak

Comment 3

[Bruce Mitchener]

Building with this in my tree to test it now!  It looks good to me though
offhand.

Comment 4

[pnunn]

Let me know if I can use you as a reviewer.
We need _2_ reviews now. (sigh).
-P

Comment 5

[Bruce Mitchener]

As I understand the rules, you only need that if you have 2 points.  I'm willing
to be a reviewer for that fix, so long as it builds and runs (which I'm waiting
to test now).

Comment 6

[pnunn]

checked in.
Closing as fixed.
-P

Comment 7

[Bruce Mitchener]

Verified just now!  Thanks.