323212 - Ctrl+c, Ctrl+v have become keyboard-layout-dependent

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Eyal Rozenberg]

for some reason, ctrl+c,ctrl+v have started to only work if I'm in English keyboard layout rather than Hebrew. Using build 2006-01-09. Has anyone else experienced this?

Comment 1

[Serge Baranov]

(In reply to comment #0)
> for some reason, ctrl+c,ctrl+v have started to only work if I'm in English
> keyboard layout rather than Hebrew. Using build 2006-01-09. Has anyone else
> experienced this?
> 

Yes, I can confirm it, see my posting here: http://forums.mozillazine.org/viewtopic.php?t=365911 .

In the recent trunk builds (somewhere between 04-01-2006 and 09-01-2006) all keyboard shortcuts stopped working when my keyboard is switched to Russian layout.

I can't copy/paste from text areas and from address bar using Ctrl+C and Ctrl+V, I can't open/close tabs using Ctrl+T and Ctrl+W unless I switch my keyboard layout back to English.

This used to work before (for sure in 03-01-2006 trunk build) and works fine in all the other applications. I think it's a major problem and should be addressed ASAP.
Currently using: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060110 Firefox/1.6a1 ID:2006011020.

I've searched bugzilla and found one patch to the bug that may have caused it: 287179. 

Found related bugs, but they say that the problem is Linux specific, mine problem appears on Windows and has started to happen only recently. 312919 and 295614 are related, but Linux specific and exist there for a while.

Comment 2

[Dainis Jonitis]

Isn't that desired?
Do we want Alt+char combinations to be layout dependent and Ctrl+char layout independent?
I werified that at least Microsoft Word handles Ctrl+C even with Russian layout.
If Mozilla wants to have some keyboard shortcuts keyboard layout independent then it should use KeyDown(or KeyUp) event instead of KeyPress.

Comment 3

[Eyal Rozenberg]

(In reply to comment #2)
> Isn't that desired?

Not at all. And the fact that this is the case on other platforms is also a bug, e.g. bug 69230 for Linux gtk.

> Do we want Alt+char combinations to be layout dependent and Ctrl+char layout
> independent?

No, Alt+Char should be independent as well.

> If Mozilla wants to have some keyboard shortcuts keyboard layout independent
> then it should use KeyDown(or KeyUp) event instead of KeyPress.

No, I disagree. That's not what the vast majority of people want, and it's not what I want.

Comment 4

[Dainis Jonitis]

How do you imagine anyone will be able to use localized version of programm that uses accelerator keys in some specific language? You won't be able to press Cyrillic letter if your keyboard will always return the latin characters even when you selected Russian keyboard layout.

Comment 5

[Eyal Rozenberg]

(In reply to comment #4)
> How do you imagine anyone will be able to use localized version of programm
> that uses accelerator keys in some specific language?

The point is that accelerator keys are effectively bound to physical keyboard keys. It's Ctrl+"the keyboard key which in English layout produces c and in my layout produces <whatever>".

> You won't be able to
> press Cyrillic letter if your keyboard will always return the latin characters
> even when you selected Russian keyboard layout.

I'm not sure what you mean by that; your keyboard won't always return latin characters; it would do what it has done up until about a week ago, in Windows.

Comment 6

[Dainis Jonitis]

Here is some interesting read about shortcuts (CTRL+letter) and accelerators (Alt+letter) and the Internationalization issues:
http://blogs.msdn.com/michkap/archive/2004/12/23/331112.aspx
http://blogs.msdn.com/michkap/archive/2004/12/24/331661.aspx

>I'm not sure what you mean by that; your keyboard won't always return latin
>characters; it would do what it has done up until about a week ago, in Windows.
Up until week ago the Win32 keyboard code was always returning latin ANSI letter if it was pressed in combination with Alt or Ctrl.

Comment 7

[Eyal Rozenberg]

(In reply to comment #6)
let's move this discussion to bug 287179.

Comment 8

[Serge Baranov]

(In reply to comment #7)
> (In reply to comment #6)
> let's move this discussion to bug 287179.
> 

Back out of patch fixing bug 287179 has fixed this issue.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060113 Firefox/1.6a1 ID:2006011318 works fine.