32323 - Edit/Bookmark properties should be disabled when no bookmarks selected

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P3)

Description

[R.K.Aa.]

Title says it all. The menuiten "Edit bookmark properties" should be visually
disabled - "grey'ed out" - when no bookmark is yet selected.

Comment 1

[R.K.Aa.]

setting invalid

Comment 2

[Blake Ross]

can you give a reason why you marked this inv?

this seems valid to me...if you have no bookmarks, the Edit | "Properties..." 
menu item in Manage Bookmarks should be disabled.

Comment 3

[Gervase Markham [:gerv]]

It is valid. Confirming.

Gerv

Comment 4

[Gervase Markham [:gerv]]

Upping severity a notch, adding polish keyword.

Gerv

Comment 5

[Chris McAfee]

m20

Comment 6

[R.K.Aa.]

"Edit bookmarks" no open with a folder or bookmark preselected, so this is still
no big bug. But when a column is selected, moz doesn't see which folder is
selected; selections vanish - and "edit bookmarks" is still not greyed out.
Clicking "edit bookmarks" in that situation (column clicked to sort) - produces
a js error:

TOP LEVEL bookmarks window got a dragJavaScript error:
chrome://communicator/content/bookmarks/bookmarks.js line 707: tree_column has
no properties

Perhaps useless info, but added it anyways ;)

Comment 7

[Blake Ross]

Reassigning 79 Bookmarks bugs to Ben.  I was told this was going to be done 
shortly about two months ago, but it clearly hasn't been.  I think that's long 
enough for all these bugs to remain assigned to nobody.

Feel free to filter all this spam into the trashcan by looking for this string 
in the message body: ducksgoquack

Comment 8

[Matthew Wilson]

Attachment: Suggested patch for consideration

Comment 9

[Matthew Wilson]

Attachment: Suggested patch for consideration (file 2)

Comment 10

[Fabian Guisset]

r=fabian under the condition that the changes be placed in a single patch (just 
do the cvs diff on the top directory (comm/bookmarks/)).
Adding approval keyword, CC'ing patch submitter and myself.

Comment 11

[Matthew Wilson]

Attachment: Combined patch, as requested

Comment 12

[Fabian Guisset]

Ben or alecf, could you sr= ?
Thanks for the patch, Matthew :)

Comment 13

[Alec Flett]

actually, this should be done in the BookmarksController, not in the onselect
handler...this works, but it's the wrong way to fix the bug.

Comment 14

[Fabian Guisset]

*** Bug 63995 has been marked as a duplicate of this bug. ***

Comment 15

[Marcia Knous [:marcia]]

Netscape Nav triage team: this is not a Netscape beta stopper.  please get patch 
reviewed and tested.

Comment 16

[Fabian Guisset]

Sorry nav triage team, my bad, the patch in this bug is wrong (see alecf's
latest comments). Removing approval keyword.

Comment 17

[Fabian Guisset]

This is fixed in the new bookmarks manager. Please note that since there is a
root folder that is selected onload, the File|properties menu item is enabled.
But if you ctrl-click (on windows) on that root folder to deselect it, the
properties menu item is grayed out.
Marking fixed.

Comment 18

[sairuh (rarely reading bugmail)]

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]