ExtensionDataSource.prototype.GetTargets passes EM_NS to stripPrefix

RESOLVED FIXED

Status

()

Toolkit
Add-ons Manager
RESOLVED FIXED
13 years ago
10 years ago

People

(Reporter: brendan, Assigned: rstrong)

Tracking

({fixed1.8.1})

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

13 years ago
EM_NS is a function.  Should pass PREFIX_NS_EM, looks like.  Found by SpiderMonkey type analysis code.

/be
(Reporter)

Comment 1

13 years ago
BTW, there's an iloop (while (1);) in ExtensionDataSource.prototype._getLocalizablePropertyValues before its only return statement, on line 6915.

/be
_getLocalizablePropertyValues and GetTargets are both borked but are easily fixed.

> taking
Assignee: bugs → robert.bugzilla
Ben, you are probably the only other person familiar with this part of this code... let me know if you have time to review this and I'll ask Benjamin if you aren't going to have the time. Thanks!
Comment on attachment 208916 [details] [diff] [review]
patch

Benjamin, though we will make the preferred way to get localized extension metadata from locale extensions I believe we should still support this method at least for the time being.
Attachment #208916 - Flags: review?(bugs) → review?(benjamin)

Updated

13 years ago
Attachment #208916 - Flags: review?(benjamin) → review+
Fixed on trunk
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v  <--  nsExtensionManager.js.in
new revision: 1.171; previous revision: 1.170
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Attachment #208916 - Flags: approval-branch-1.8.1+
Checked in to MOZILLA_1_8_BRANCH
Keywords: fixed1.8.1
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.