[Skinnability] Taskbar icons and taskbaroverlay.css are flawed

RESOLVED INVALID

Status

Core Graveyard
Skinability
P3
normal
RESOLVED INVALID
18 years ago
6 years ago

People

(Reporter: David Hyatt, Unassigned)

Tracking

({helpwanted, polish})

Trunk
Future
x86
Windows NT
helpwanted, polish

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

18 years ago
taskbarOverlay.css should not point to any images, especially mailnews, which 
might not even be installed.

The icons should be moved into individual component packages, e.g., navigator, 
mailnews, etc. and should place themselvesi nto the taskbar using overlays.  
They should each have little style sheets that specify their icons.

I don't really mind if navigator, composer, etc. stay in taskbarOverlay.css and 
in global, but mailnews, aim and all "pluggable" components need to move out of 
global.

Comment 1

18 years ago
Adding 'skins' keyword to appropriate bugs en masse, sorry about any 
mistakes...
Keywords: skins

Updated

18 years ago
Blocks: 29160

Comment 2

18 years ago
Should this bug be targetted for M16 as part of the skinnability push for B2?  
Could you please set the target so we know whether to expect it?

Comment 3

18 years ago
Mass-adding beta2 keyword to all skins bugs.
Keywords: beta2

Comment 4

18 years ago
M16 ...
Priority: P3 → P1
Target Milestone: --- → M16

Updated

18 years ago
Keywords: nsbeta2

Comment 5

18 years ago
adding to nsbeta2+ radar per pdt
Keywords: beta2
Whiteboard: [nsbeta2+]
This involves me creating/adding to dynamic stylesheets for the mailnews and AIM 
packages, and some makefile hackery. Time to complete: 1/2 day. 
Status: NEW → ASSIGNED

Comment 7

18 years ago
Move to M18.
Target Milestone: M16 → M18

Comment 8

18 years ago
->skinability
Component: Browser-General → Skinability
QA Contact: asa → BlakeR1234

Comment 9

18 years ago
Per todays PDT Nav Beta 2 review, moving to [nsbeta2-].
Whiteboard: [nsbeta2+] → [nsbeta2-]

Comment 10

18 years ago
nav triage team:
easy to fix, important for skins and nav only install, b3nav+, unpredicatable 
behavior if you click on the icon when the app isn't installed.
Keywords: correctness
Whiteboard: [nsbeta2-] → [nsbeta2-][b3nav+]

Comment 11

18 years ago
nav triage team: [b3nav+] now = nsbeta3+
Whiteboard: [nsbeta2-][b3nav+] → [nsbeta2-][nsbeta3+]
Adding nsbeta3 keyword to bugs which already have nsbeta3 status markings so 
the queries don't get all screwed up.
Keywords: nsbeta3
Priority: P1 → P3

Comment 13

18 years ago
nav triage team:
Blake, do you know what happens with the code today if you do a Nav only install
and click on the Mail button in the Task Bar?  Depending on how this reacts, we
may push up or down the priority of fixing this.
Whiteboard: [nsbeta2-][nsbeta3+] → [nsbeta2-][nsbeta3+][NEED INFO]

Comment 14

18 years ago
Just did a navigator-only install and in 2000082208, the Mail button isn't in 
the component bar of the taskbar, nor is there an item in the Tasks menu.  The 
Address Book, however, appeared in both locations, despite not being installed -
- but that's bug 46596, so I don't know what this is still tracking.  Just for 
reference, when I tried to access the uninstalled Address Book via the 
component bar and the Tasks menu, nothing happened except the appearance of 
this error in the console:

JavaScript error:
 line 0: toAddressBook is not defined

Which is quite logical since it's not installed.

Comment 15

18 years ago
Nav triage team: Changing to nsbeta3-; Blake, can you check and see if this can 
be closed since it may no longer be tracking any real problem? Thanks.
Whiteboard: [nsbeta2-][nsbeta3+][NEED INFO] → [nsbeta2-][nsbeta3-]
OK, it's time for me to factor the AB icon. Clearing status whiteboard/keyword
cruft and nominating for nsbeta1.

Management types: the remaining work here involves me shifting the inclusion of
the AddressBook taskbar icon into a dynamic overlay included in navigator by
mail so that it does not appear if mail is not installed. Requires a small
amount of tedious work. No biggie, bad polish flaw. 
Keywords: nsbeta2, nsbeta3 → nsbeta1
Whiteboard: [nsbeta2-][nsbeta3-]

Updated

17 years ago
Keywords: skins

Comment 17

17 years ago
Adding polish keyword, resetting target milestone, marking nsbeta1- since I
doubt Ben will get to this for beta1
Keywords: nsbeta1 → nsbeta1-, polish
Target Milestone: M18 → ---

Comment 18

17 years ago
Marking nsbeta1- bugs as future to get off the radar
Target Milestone: --- → Future

Updated

17 years ago
QA Contact: blakeross → pmac
Mass move skinability bugs to nobody@mozilla.org, helpwanted. 
Assignee: ben → nobody
Status: ASSIGNED → NEW
Keywords: helpwanted

Comment 20

17 years ago
Now that bug 46596 is fixed what is this bug for?

Comment 21

16 years ago
Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.1) Gecko/20020826

Install every theme at themes.mozdev.org and for each theme do not allow it to 
be applied (only install). 
While this is in progress, at some point, a mouse over the component bar will 
set component icons for the onMouseOver event to other icons then the current 
theme.
Filter on "Nobody_NScomTLD_20080620"
QA Contact: pmac → skinability
(Assignee)

Updated

10 years ago
Product: Core → Core Graveyard

Comment 23

6 years ago
taskbarOverlay.css does not exist any more.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.