Xlib build fails in nsGfxFactoryXlib.cpp following bug 322942

RESOLVED FIXED

Status

Core Graveyard
GFX: Xlib
--
minor
RESOLVED FIXED
12 years ago
9 years ago

People

(Reporter: Kenneth Herron, Assigned: Kenneth Herron)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

6.21 KB, patch
Biesinger
: review+
Stuart Parmenter
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

12 years ago
Xlib builds fail while compiling nsGfxFactoryXlib.cpp, complaining about NS_SCREENMANAGER_CID not found. Bug 322942 moved nsIScreen and its implementations from gfx to widget; it included fixes for the major gfx implementations but not xlib.
(Assignee)

Comment 1

12 years ago
Created attachment 208529 [details] [diff] [review]
Xlib fix

This contains the code changes. It's based on the patch in bug 322942 and the BeOS patch in bug 323352. I've verified that xlib builds and runs with this change.

The files files nsScreenManagerXlib.cpp, nsScreenManagerXlib.h, nsScreenXlib.cpp, and nsScreenXlib.h were copied from gfx/src/xlib to widget/src/xlib and currently appear in both directories. I presume the gfx versions should be removed via cvs as part of the checkin.
Attachment #208529 - Flags: superreview?
Attachment #208529 - Flags: review?
(Assignee)

Updated

12 years ago
Attachment #208529 - Flags: superreview?(pavlov)
Attachment #208529 - Flags: superreview?
Attachment #208529 - Flags: review?(cbiesinger)
Attachment #208529 - Flags: review?

Updated

12 years ago
Attachment #208529 - Flags: superreview?(pavlov) → superreview+
Blocks: 322942
Attachment #208529 - Flags: review?(cbiesinger) → review+
(Assignee)

Comment 2

12 years ago
Checked in. Thanks for the quick reviews!
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.