323525 - Style the group table as all other tables in Bugzilla

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Paul]

When pressing groups (editgroups.cgi) you get a table.  This table does not have the same look as other tables in Bugzilla.

Comment 1

[Frédéric Buclin]

template/en/default/admin/groups/list.html.tmpl should use template/en/default/admin/table.html.tmpl.

Comment 2

[Colin Ogilvie [:cso]]

Attachment: Patch v1

Patch v1

Comment 3

[Frédéric Buclin]

Comment on attachment 209397 [details] [diff] [review]
Patch v1


>+   {name               => 'userregexp'
>+    heading            => 'User RegExp'
>+    allow_html_content => 1
>+   }

No, no html content is allowed here. It must be filtered.


>+   {name               => 'use_for'
>+    heading            => "Use For $terms.Bugs"
>+    allow_html_content => 1
>+   }

Same remark here.


>+[% FOREACH group = groups %]
>+  [% group.name = BLOCK %]
>+    [% group.name FILTER html %]
>+  [% END %]

No need to filter fields here. table.html.tmpl does it for you already, unless allow_html_content is set.


>+  [% group.userregexp = BLOCK %]
>+    [% IF group.userregexp %]
>+      [% group.userregexp FILTER html %]
>+    [% ELSE %]
>+      [% " " FILTER none %]
>+    [% END %]
>+  [% END %]

Use 'overrides' for that. Read the INTERFACE of table.html.tmpl for more information.


>+  [% group.use_for = BLOCK %]
>+      [% IF (group.isactive != 0) && (group.isbuggroup) %]
>+        X
>+      [% ELSE %]
>+         
>+      [% END %]
>+  [% END %]

Same remark here.


>+  [% group.type = BLOCK %]
>+    [% (group.isbuggroup) ? "user" : "system" %]
>+  [% END %]

And here.

Comment 4

[Colin Ogilvie [:cso]]

(In reply to comment #3)
> (From update of attachment 209397 [details] [diff] [review] [edit])
> 
> >+   {name               => 'userregexp'
> >+    heading            => 'User RegExp'
> >+    allow_html_content => 1
> >+   }
> 
> No, no html content is allowed here. It must be filtered.

The only way to get   to appear (as far as I could see) was to allow_html_content. 

> Use 'overrides' for that. Read the INTERFACE of table.html.tmpl
> for more information.

I've read the INTERFACE, and I've looked at the example, and I'm completely baffled as to how it works.

Comment 5

[Colin Ogilvie [:cso]]

Attachment: Patch v2.

I think I finally got the hang of interfaces...

Comment 6

[Colin Ogilvie [:cso]]

Attachment: Patch v2.

I think I finally got the hang of interfaces...

Comment 7

[Frédéric Buclin]

Comment on attachment 215586 [details] [diff] [review]
Patch v2.


>+   {name               => 'use_for'
>+    heading            => "Use For $terms.Bugs"
>+   }
>+   {name               => 'type'
>+    heading            => 'Type'
>+   }

Please add: align => 'center' for both of them. This can be fixed on checkin. r=LpSolit

Comment 8

[Frédéric Buclin]

Checking in template/en/default/admin/groups/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/groups/list.html.tmpl,v  <--  list.html.tmpl
new revision: 1.5; previous revision: 1.4
done

Comment 9

[Frédéric Buclin]

We need it on 2.22 to check in bug 324784.

Comment 10

[Dave Miller [:justdave]]

reopening just to make sure it doesn't get lost since we still have pending checkin

Comment 11

[Frédéric Buclin]

2.22:

Checking in template/en/default/admin/groups/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/groups/list.html.tmpl,v  <--  list.html.tmpl
new revision: 1.4.2.1; previous revision: 1.4
done