Date picker doesn't handle refresh correctly

RESOLVED FIXED

Status

Core Graveyard
XForms
RESOLVED FIXED
12 years ago
a year ago

People

(Reporter: aaronr, Assigned: Doron Rosenberg (IBM))

Tracking

({fixed1.8.0.4, fixed1.8.1})

Trunk
x86
All
fixed1.8.0.4, fixed1.8.1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

12 years ago
inputs bound to dates don't handle refresh correctly.  They don't ever show their initial values and other date pickers bound to the same changed node won't show the changed value.  Testcase to follow.
(Reporter)

Comment 1

12 years ago
There is also another problem.  If @incremental="true", then datepickers bound to the same node should change at the same time, without the user moving focus away from the input field.
(Reporter)

Updated

12 years ago
Assignee: aaronr → doronr
(Reporter)

Comment 2

12 years ago
Created attachment 208677 [details]
testcase
(Assignee)

Comment 3

12 years ago
(In reply to comment #1)
> There is also another problem.  If @incremental="true", then datepickers bound
> to the same node should change at the same time, without the user moving focus
> away from the input field.
> 

Is this all fixed by removing the refresh method from the xbl?
(Reporter)

Comment 4

12 years ago
(In reply to comment #3)
> (In reply to comment #1)
> > There is also another problem.  If @incremental="true", then datepickers bound
> > to the same node should change at the same time, without the user moving focus
> > away from the input field.
> > 
> 
> Is this all fixed by removing the refresh method from the xbl?
> 

the @incremental bug isn't fixed by removing date picker's "refresh" method.  But removing "refresh" (and thus using input's default refresh) does fix the initialization problem and the update problem.
(Assignee)

Comment 5

12 years ago
Created attachment 208739 [details] [diff] [review]
patch

First, remove the refresh method that was doing a no-op to fix the instance loading issue.

Secondly, fix a missing bracket bug.

Thirdly, add some _change() calls when the input field changes.
Attachment #208739 - Flags: review?(aaronr)
(Assignee)

Updated

12 years ago
Attachment #208739 - Flags: review?(smaug)
(Reporter)

Comment 6

12 years ago
Comment on attachment 208739 [details] [diff] [review]
patch

In reviewing your patch I also saw that readonly won't work right for date picker.  I'll open another bug for that, though.
Attachment #208739 - Flags: review?(aaronr) → review+
Attachment #208739 - Flags: review?(smaug) → review+
(Reporter)

Updated

12 years ago
Blocks: 326372
(Reporter)

Updated

12 years ago
Blocks: 326373

Comment 7

12 years ago
(In reply to comment #5)
> Created an attachment (id=208739) [edit]
> patch
> 
> First, remove the refresh method that was doing a no-op to fix the instance
> loading issue.

I wanted to check this in, but bug 323829 actually ads functionality to refresh(). What was the issue exactly? The testcase seems to work fine for me with the patch applied (except for the killing of refresh).

Could you check it in Doron, if all is well, etc.?
(Assignee)

Comment 8

12 years ago
checked into trunk
Status: NEW → ASSIGNED
Whiteboard: xf-to-branch
(Reporter)

Updated

12 years ago
Blocks: 326556

Updated

12 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

12 years ago
Blocks: 332853

Updated

12 years ago
Keywords: fixed1.8.0.3, fixed1.8.1

Updated

12 years ago
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.