Closed Bug 323683 Opened 15 years ago Closed 15 years ago

Date picker doesn't handle refresh correctly

Categories

(Core Graveyard :: XForms, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aaronr, Assigned: doronr)

References

Details

(Keywords: fixed1.8.0.4, fixed1.8.1)

Attachments

(2 files)

inputs bound to dates don't handle refresh correctly.  They don't ever show their initial values and other date pickers bound to the same changed node won't show the changed value.  Testcase to follow.
There is also another problem.  If @incremental="true", then datepickers bound to the same node should change at the same time, without the user moving focus away from the input field.
Assignee: aaronr → doronr
Attached file testcase
(In reply to comment #1)
> There is also another problem.  If @incremental="true", then datepickers bound
> to the same node should change at the same time, without the user moving focus
> away from the input field.
> 

Is this all fixed by removing the refresh method from the xbl?
(In reply to comment #3)
> (In reply to comment #1)
> > There is also another problem.  If @incremental="true", then datepickers bound
> > to the same node should change at the same time, without the user moving focus
> > away from the input field.
> > 
> 
> Is this all fixed by removing the refresh method from the xbl?
> 

the @incremental bug isn't fixed by removing date picker's "refresh" method.  But removing "refresh" (and thus using input's default refresh) does fix the initialization problem and the update problem.
Attached patch patchSplinter Review
First, remove the refresh method that was doing a no-op to fix the instance loading issue.

Secondly, fix a missing bracket bug.

Thirdly, add some _change() calls when the input field changes.
Attachment #208739 - Flags: review?(aaronr)
Attachment #208739 - Flags: review?(smaug)
Comment on attachment 208739 [details] [diff] [review]
patch

In reviewing your patch I also saw that readonly won't work right for date picker.  I'll open another bug for that, though.
Attachment #208739 - Flags: review?(aaronr) → review+
Attachment #208739 - Flags: review?(smaug) → review+
Blocks: 326372
Blocks: 326373
(In reply to comment #5)
> Created an attachment (id=208739) [edit]
> patch
> 
> First, remove the refresh method that was doing a no-op to fix the instance
> loading issue.

I wanted to check this in, but bug 323829 actually ads functionality to refresh(). What was the issue exactly? The testcase seems to work fine for me with the patch applied (except for the killing of refresh).

Could you check it in Doron, if all is well, etc.?
checked into trunk
Status: NEW → ASSIGNED
Whiteboard: xf-to-branch
Blocks: 326556
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Blocks: 332853
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.