323736 - Bogus closing tag syntax comment parsed as an SGML comment

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect, P4)

Description

[Simon Pieters [:zcorpan]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060116 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060116 Firefox/1.6a1

Comments that start with "</" should be parsed the traditional way, i.e. close the comment upon the first ">", rather than as an "SGML" comment.

Reproducible: Always

Steps to Reproduce:
1. Open data:text/html,<!DOCTYPE html><p></-->PASS<!-->FAIL<! -->
2.
3.

Actual Results:  
There are two comments, ">PASS<!" and " --".

Expected Results:  
</--> should be parsed as a bogus comment, containing "--".

Comment 1

[Hermann Schwab]

added reporter's testcase into URL:

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Easy fix

This ensures that strict comments do really start with <!--. It also fixes an illegal use of |static NS_NAMED_LITERAL_STRING(...)|.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 208751 [details] [diff] [review]
Easy fix

r+sr=jst

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into trunk.