Bogus closing tag syntax comment parsed as an SGML comment

RESOLVED FIXED in mozilla1.9alpha1

Status

()

Core
HTML: Parser
P4
trivial
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Simon Pieters, Assigned: mrbkap)

Tracking

Trunk
mozilla1.9alpha1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060116 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060116 Firefox/1.6a1

Comments that start with "</" should be parsed the traditional way, i.e. close the comment upon the first ">", rather than as an "SGML" comment.

Reproducible: Always

Steps to Reproduce:
1. Open data:text/html,<!DOCTYPE html><p></-->PASS<!-->FAIL<! -->
2.
3.

Actual Results:  
There are two comments, ">PASS<!" and " --".

Expected Results:  
</--> should be parsed as a bogus comment, containing "--".

Comment 1

12 years ago
added reporter's testcase into URL:
(Assignee)

Updated

12 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 2000 → All
Priority: -- → P4
Hardware: PC → All
Target Milestone: --- → mozilla1.9alpha
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

12 years ago
Created attachment 208751 [details] [diff] [review]
Easy fix

This ensures that strict comments do really start with <!--. It also fixes an illegal use of |static NS_NAMED_LITERAL_STRING(...)|.
Attachment #208751 - Flags: superreview?(jst)
Attachment #208751 - Flags: review?(jst)
Comment on attachment 208751 [details] [diff] [review]
Easy fix

r+sr=jst
Attachment #208751 - Flags: superreview?(jst)
Attachment #208751 - Flags: superreview+
Attachment #208751 - Flags: review?(jst)
Attachment #208751 - Flags: review+
(Assignee)

Comment 4

12 years ago
Fix checked into trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.