323842 - Add "Allow for session" option in cookie acceptance sheet

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[Chris Lawson (gone)]

Instead of the full monty of a disclosure triangle, etc. being added to the cookie acceptance sheet, we should simply have an "Allow for session" button, as requested by bug 173521 comment 7 and bug 173521 comment 9 (as well as multiple requests elsewhere). This adds only a modicum of complexity, and as has been pointed out elsewhere, will not even be visible to novice users unless "Ask before accepting" is checked in the privacy prefs.

Patch is already done and will be coming along shortly.

Comment 1

[Chris Lawson (gone)]

Attachment: puts "Allow for session" button on cookie request sheet

Comment 2

[Chris Lawson (gone)]

Accepting.

Note about the patch: there were a *lot* of minor whitespace changes that do nothing as far as code goes. They're in the patch but if a reviewer wants them out, I can re-diff.

cl

Comment 3

[Chris Lawson (gone)]

Minor error: "Session" should be capitalised. I can upload a new patch, or once this is reviewed, the check-in person can do it.

cl

Comment 4

[Chris Lawson (gone)]

Attachment: Fixes capitalisation, cleans up logic per Stuart's comments on IRC

Comment 5

[Chris Lawson (gone)]

Attachment: screenshot of sheet in action

For non-coders who are interested in what this looks like.

cl

Comment 6

[Chris Lawson (gone)]

Attachment: fixes broken sort, rearranges popup menu items to sort properly

Comment 7

[Chris Lawson (gone)]

Comment on attachment 208938 [details] [diff] [review]
fixes broken sort, rearranges popup menu items to sort properly

Errrr...ignore that patch. It's for the related bug 302865 ;)

cl

Comment 8

[Chris Lawson (gone)]

Comment on attachment 208836 [details] [diff] [review]
Fixes capitalisation, cleans up logic per Stuart's comments on IRC

...and this isn't obsolete, either.

cl

Comment 9

[Stuart Morgan]

Comment on attachment 208836 [details] [diff] [review]
Fixes capitalisation, cleans up logic per Stuart's comments on IRC

r=me.  Works as advertized.

This shouldn't be checked in without the patch for bug 302865, or the policy-editing table will be wrong.

Also needs "Allow for Session" added to the Localizable.strings when commited.

Comment 10

[Chris Lawson (gone)]

Attachment: Updated for bitrotting, logic clean-up

Also fixes a couple style issues earlier in the file.

cl

Comment 11

[Simon Fraser [no longer active]]

Comment on attachment 210056 [details] [diff] [review]
Updated for bitrotting, logic clean-up

No tabs please.

Comment 12

[Chris Lawson (gone)]

Attachment: tab-less version of previous patch

Comment 13

[Chris Lawson (gone)]

Attachment: really tab-less version of previous previous patch

Aaaaargh! Bloody hell.

Sorry for the bugspam.

cl

Comment 14

[Samuel Sidler (old account; do not CC)]

-> 1.1

Comment 15

[Stuart Morgan]

Comment on attachment 210064 [details] [diff] [review]
really tab-less version of previous previous patch

Some slacker took too long reviewing this, and it bitrotted.  Please re-spin, and I promise to be a bit more prompt with that version.

Comment 16

[Chris Lawson (gone)]

Attachment: updated for bitrot

I coulda sworn I uploaded this two days ago, but apparently not.

cl

Comment 17

[Stuart Morgan]

Comment on attachment 213542 [details] [diff] [review]
updated for bitrot

r=me with the conditions that:
- bug 302865 lands first/at the same time
- the commiter makes the strings addition

Comment 18

[Mark Mentovai]

Checked in on the trunk and 1.8 branch.

(Someone better begin keeping track of stuff for the 1.1 release notes.)

Comment 19

[[e-mail]]

Verified on 1.8 branch and trunk