Closed Bug 323842 Opened 15 years ago Closed 15 years ago

Add "Allow for session" option in cookie acceptance sheet

Categories

(Camino Graveyard :: General, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Camino1.5

People

(Reporter: bugzilla-graveyard, Assigned: bugzilla-graveyard)

References

(Blocks 1 open bug)

Details

(Keywords: fixed1.8.1)

Attachments

(2 files, 6 obsolete files)

Instead of the full monty of a disclosure triangle, etc. being added to the cookie acceptance sheet, we should simply have an "Allow for session" button, as requested by bug 173521 comment 7 and bug 173521 comment 9 (as well as multiple requests elsewhere). This adds only a modicum of complexity, and as has been pointed out elsewhere, will not even be visible to novice users unless "Ask before accepting" is checked in the privacy prefs.

Patch is already done and will be coming along shortly.
Accepting.

Note about the patch: there were a *lot* of minor whitespace changes that do nothing as far as code goes. They're in the patch but if a reviewer wants them out, I can re-diff.

cl
Status: NEW → ASSIGNED
Minor error: "Session" should be capitalised. I can upload a new patch, or once this is reviewed, the check-in person can do it.

cl
Attachment #208823 - Attachment is obsolete: true
Attachment #208836 - Flags: review?
Attachment #208823 - Flags: review?
For non-coders who are interested in what this looks like.

cl
Attachment #208836 - Attachment is obsolete: true
Attachment #208938 - Flags: review?(stuart.morgan)
Attachment #208836 - Flags: review?
Comment on attachment 208938 [details] [diff] [review]
fixes broken sort, rearranges popup menu items to sort properly

Errrr...ignore that patch. It's for the related bug 302865 ;)

cl
Attachment #208938 - Attachment is obsolete: true
Attachment #208938 - Flags: review?(stuart.morgan)
Comment on attachment 208836 [details] [diff] [review]
Fixes capitalisation, cleans up logic per Stuart's comments on IRC

...and this isn't obsolete, either.

cl
Attachment #208836 - Attachment is obsolete: false
Attachment #208836 - Flags: review?(stuart.morgan)
Comment on attachment 208836 [details] [diff] [review]
Fixes capitalisation, cleans up logic per Stuart's comments on IRC

r=me.  Works as advertized.

This shouldn't be checked in without the patch for bug 302865, or the policy-editing table will be wrong.

Also needs "Allow for Session" added to the Localizable.strings when commited.
Attachment #208836 - Flags: superreview?
Attachment #208836 - Flags: review?(stuart.morgan)
Attachment #208836 - Flags: review+
Also fixes a couple style issues earlier in the file.

cl
Attachment #208836 - Attachment is obsolete: true
Attachment #210056 - Flags: superreview?(sfraser_bugs)
Attachment #210056 - Flags: review?(stuart.morgan)
Attachment #208836 - Flags: superreview?
Comment on attachment 210056 [details] [diff] [review]
Updated for bitrotting, logic clean-up

No tabs please.
Attachment #210056 - Flags: superreview?(sfraser_bugs) → superreview-
Attachment #210056 - Attachment is obsolete: true
Attachment #210063 - Flags: superreview?(sfraser_bugs)
Attachment #210063 - Flags: review?(stuart.morgan)
Attachment #210056 - Flags: review?(stuart.morgan)
Aaaaargh! Bloody hell.

Sorry for the bugspam.

cl
Attachment #210063 - Attachment is obsolete: true
Attachment #210064 - Flags: superreview?(sfraser_bugs)
Attachment #210064 - Flags: review?(stuart.morgan)
Attachment #210063 - Flags: superreview?(sfraser_bugs)
Attachment #210063 - Flags: review?(stuart.morgan)
-> 1.1
Target Milestone: Camino1.0 → Camino1.1
Comment on attachment 210064 [details] [diff] [review]
really tab-less version of previous previous patch

Some slacker took too long reviewing this, and it bitrotted.  Please re-spin, and I promise to be a bit more prompt with that version.
Attachment #210064 - Flags: superreview?(sfraser_bugs)
Attachment #210064 - Flags: review?(stuart.morgan)
Attachment #210064 - Flags: review-
I coulda sworn I uploaded this two days ago, but apparently not.

cl
Attachment #210064 - Attachment is obsolete: true
Attachment #213542 - Flags: review?(stuart.morgan)
Comment on attachment 213542 [details] [diff] [review]
updated for bitrot

r=me with the conditions that:
- bug 302865 lands first/at the same time
- the commiter makes the strings addition
Attachment #213542 - Flags: superreview?
Attachment #213542 - Flags: review?(stuart.morgan)
Attachment #213542 - Flags: review+
Blocks: 174070
Attachment #213542 - Flags: superreview? → superreview+
Checked in on the trunk and 1.8 branch.

(Someone better begin keeping track of stuff for the 1.1 release notes.)
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Verified on 1.8 branch and trunk
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.