323946 - nsFieldSetFrame does not need a space manager

Status: RESOLVED FIXED

(Core :: Layout: Floats, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

nsFieldSetFrame's anonymous child block already has a space manager, so the only way nsFieldSetFrame's space manager can be used is if the legend contains floats, and then I think things are going to go wrong ... nsLegendFrame should have its own space manager. Then we can get rid of nsFieldSetFrame's space manager. This will create the reasonable invariant that only block frames have space managers.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Fix as described.

This patch includes the fix for bug 309550. I've filed this bug separately with separate patches on the chance than the patch in bug 309550 might be wanted on branch.

I've tested that this does not regress bug 200347, and works OK with floats in a legend.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Doesn't NS_NewLegendFrame need to actually return f?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yes.  Oops.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in, with "return f;" added.