Closed Bug 323956 Opened 15 years ago Closed 15 years ago

Missing xpinstall prefs for XULRunner

Categories

(Toolkit Graveyard :: XULRunner, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

The following prefs are needed by xpinstall to install extensions with XULRunner. The missing "Get More" url prefs are probably better handled by not displaying the "Get More" ui instead of adding defaults and will be handled in bug 313141.

pref("xpinstall.dialog.confirm", "chrome://mozapps/content/xpinstall/xpinstallConfirm.xul");
pref("xpinstall.dialog.progress.chrome", "chrome://mozapps/content/extensions/extensions.xul?type=extensions");
pref("xpinstall.dialog.progress.skin", "chrome://mozapps/content/extensions/extensions.xul?type=themes");
pref("xpinstall.dialog.progress.type.chrome", "Extension:Manager-extensions");
pref("xpinstall.dialog.progress.type.skin", "Extension:Manager-themes");
pref("xpinstall.enabled", true);
Attached patch patchSplinter Review
Besides adding the prefs this also removes the installed-extensions.txt and Extensions.rdf from the makefile so they are no longer added to the extensions directory of new profiles.
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #209133 - Flags: first-review?(benjamin)
Comment on attachment 209133 [details] [diff] [review]
patch

Hrm, I wonder about "xpinstall.disabled"... perhaps that should be keyed so that it always matches the value of the application.ini enable-extensionmanager flag.
Attachment #209133 - Flags: first-review?(benjamin) → first-review+
(In reply to comment #2)
> (From update of attachment 209133 [details] [diff] [review] [edit])
> Hrm, I wonder about "xpinstall.disabled"... perhaps that should be keyed so
> that it always matches the value of the application.ini enable-extensionmanager
> flag.
I considered setting xpinstall.enabled based on that at first and decided against it since it isn't Extension Manager specific and adds complexity but I could go either way.
Comment on attachment 209133 [details] [diff] [review]
patch

Let's leave it like this for the while and see whether that causes problems.
Attachment #209133 - Flags: approval1.8.1+
Checked in to Trunk and MOZILLA_1_8_BRANCH
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Depends on: 326238
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.