323956 - Missing xpinstall prefs for XULRunner

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[Robert Strong (they/them - no direct email)]

The following prefs are needed by xpinstall to install extensions with XULRunner. The missing "Get More" url prefs are probably better handled by not displaying the "Get More" ui instead of adding defaults and will be handled in bug 313141.

pref("xpinstall.dialog.confirm", "chrome://mozapps/content/xpinstall/xpinstallConfirm.xul");
pref("xpinstall.dialog.progress.chrome", "chrome://mozapps/content/extensions/extensions.xul?type=extensions");
pref("xpinstall.dialog.progress.skin", "chrome://mozapps/content/extensions/extensions.xul?type=themes");
pref("xpinstall.dialog.progress.type.chrome", "Extension:Manager-extensions");
pref("xpinstall.dialog.progress.type.skin", "Extension:Manager-themes");
pref("xpinstall.enabled", true);

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

Besides adding the prefs this also removes the installed-extensions.txt and Extensions.rdf from the makefile so they are no longer added to the extensions directory of new profiles.

Comment 2

[Benjamin Smedberg]

Comment on attachment 209133 [details] [diff] [review]
patch

Hrm, I wonder about "xpinstall.disabled"... perhaps that should be keyed so that it always matches the value of the application.ini enable-extensionmanager flag.

Comment 3

[Robert Strong (they/them - no direct email)]

(In reply to comment #2)
> (From update of attachment 209133 [details] [diff] [review] [edit])
> Hrm, I wonder about "xpinstall.disabled"... perhaps that should be keyed so
> that it always matches the value of the application.ini enable-extensionmanager
> flag.
I considered setting xpinstall.enabled based on that at first and decided against it since it isn't Extension Manager specific and adds complexity but I could go either way.

Comment 4

[Benjamin Smedberg]

Comment on attachment 209133 [details] [diff] [review]
patch

Let's leave it like this for the while and see whether that causes problems.

Comment 5

[Robert Strong (they/them - no direct email)]

Checked in to Trunk and MOZILLA_1_8_BRANCH