324111 - Extension Manager window is empty (e.g. datasource not loaded) when the extensions.rdf is corrupt

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

There have been a couple of reports where the extensions.rdf exists but is corrupt (see bug 322118, comment #9) and we make no attempt to recover. This seems like something we should do if we throw when we call GetDataSourceBlocking on the extensions.rdf.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: real life example of a corrupted extensions.rdf

Comment 2

[Robert Strong (they/them - no direct email)]

Comment on attachment 209077 [details]
real life example of a corrupted extensions.rdf

To view the contents of this file first download it and then open it in a text editor.

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch

Removes the extensions.rdf so it will be regenerated on restart. Since the extensions datasource can be loaded well after app startup we can't do anything fancy like restart when this is detected. There is no user notification that they will need to restart and Extension Manager operations will not succeed until after the user restarts. With this being an edgecase I don't think we need to do anything more than this.

btw: I haven't been able to reproduce this bug where the extensions datasource is filled with null chars so I don't have any idea as to what the root cause is. I do know that removing the extensions datasource in order to allow it to regenerate has fixed this bug for the couple of people I have been in contact with that have experienced this.

Comment 4

[Robert Strong (they/them - no direct email)]

Checked in on trunk

Comment 5

[Robert Strong (they/them - no direct email)]

Checked in to MOZILLA_1_8_BRANCH

Comment 6

[Robert Strong (they/them - no direct email)]

*** Bug 332998 has been marked as a duplicate of this bug. ***

Comment 7

[Robert Strong (they/them - no direct email)]

*** Bug 338187 has been marked as a duplicate of this bug. ***

Comment 8

[Robert Strong (they/them - no direct email)]

*** Bug 341904 has been marked as a duplicate of this bug. ***

Comment 9

[Sebastian]

*** Bug 345628 has been marked as a duplicate of this bug. ***

Comment 10

[Robert Strong (they/them - no direct email)]

*** Bug 307845 has been marked as a duplicate of this bug. ***

Comment 11

[Robert Strong (they/them - no direct email)]

*** Bug 346272 has been marked as a duplicate of this bug. ***

Comment 12

[Robert Strong (they/them - no direct email)]

*** Bug 349117 has been marked as a duplicate of this bug. ***

Comment 13

[Robert Strong (they/them - no direct email)]

*** Bug 355464 has been marked as a duplicate of this bug. ***