Closed
Bug 324124
Opened 19 years ago
Closed 19 years ago
nsCOMPtr can be constructed with const char* and nsID
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
People
(Reporter: jag+mozilla, Assigned: jag+mozilla)
Details
Attachments
(1 file)
|
822 bytes,
patch
|
benjamin
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
See also bug 317911.
// this constructs a nsGetServiceByContractID temporary
nsCOMPtr<nsIFoo> foo("foo");
It may seem like a nifty shortcut for do_GetService(), but I don't think we should allow it. Similar for nsID and nsGetServiceByCID. Patch coming up.
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #209088 -
Flags: superreview?(dbaron)
Attachment #209088 -
Flags: review?(benjamin)
Attachment #209088 -
Flags: superreview?(dbaron) → superreview+
|
||
Updated•19 years ago
|
Attachment #209088 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 2•19 years ago
|
||
Checking in nsCOMPtr.h;
/cvsroot/mozilla/xpcom/glue/nsCOMPtr.h,v <-- nsCOMPtr.h
new revision: 1.122; previous revision: 1.121
done
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•